Skip to content

Commit 052a7a8

Browse files
authored
Add cdk group to dependabot (#14382)
Historically `guardian/cdk` has specified exact versions of the CDK libraries (`aws-cdk`, `aws-cdk-lib` and `constructs`) as peer dependencies. This has made it difficult to rely on dependabot for updates, because it will try to update past these versions. It's possible npm 7's default peer dependency behaviour or pnpm's `strictPeerDependencies` could be used to mitigate this, but not all projects (including this one) are configured this way. As a consequence, we've typically had to ignore those dependencies, and update them manually instead. However, `guardian/cdk` has recently relaxed its requirements, instead specifying minimum versions of the CDK libraries that it's compatible with: guardian/cdk#2698 This allows us to create a dependabot group to have all three CDK libraries and `guardian/cdk` updated together. Whenever a new version of `guardian/cdk` is published, the minimum versions of the CDK libraries that it depends on should already exist, so grouped PRs should always contain at least the minimum versions required.
1 parent 86dcb37 commit 052a7a8

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

.github/dependabot.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@ updates:
1010
schedule:
1111
interval: 'daily'
1212
ignore:
13-
# The version of the aws-cdk[-lib] & constructs dependencies should match
14-
# exactly the version specified by @guardian/cdk
15-
- dependency-name: 'aws-cdk'
16-
- dependency-name: 'aws-cdk-lib'
17-
- dependency-name: 'constructs'
1813
# The `check-node-versions` script enforces that this package is kept in
1914
# sync with our Node major version, so we want dependabot to ignore major
2015
# version updates, but still allow smaller updates.
@@ -29,6 +24,12 @@ updates:
2924
babel:
3025
patterns:
3126
- '*babel*'
27+
cdk:
28+
patterns:
29+
- '@guardian/cdk'
30+
- 'aws-cdk'
31+
- 'aws-cdk-lib'
32+
- 'constructs'
3233
eslint:
3334
patterns:
3435
- '*eslint*'

0 commit comments

Comments
 (0)