Skip to content

Commit 08e1b56

Browse files
committed
address PR review comments
1 parent 4d135d6 commit 08e1b56

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

dotcom-rendering/src/components/LightboxLink.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,8 @@ export const LightboxLink = ({
151151
`,
152152
decideSize(role, format),
153153
isMainMedia &&
154-
format.display === ArticleDisplay.Immersive &&
154+
(format.display === ArticleDisplay.Immersive ||
155+
format.design === ArticleDesign.Gallery) &&
155156
visuallyHidden,
156157
]}
157158
>

dotcom-rendering/src/components/MainMediaGallery.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ type Props = {
1919

2020
const styles = css`
2121
${grid.column.all}
22+
position: relative;
2223
height: calc(80vh - 48px);
2324
grid-row: 1/8;
2425
${from.desktop} {
@@ -56,7 +57,7 @@ export const MainMediaGallery = ({
5657
alt={mainMedia.data.alt ?? ''}
5758
width={width}
5859
height={height}
59-
loading={'lazy'}
60+
loading="eager"
6061
/>
6162
</Island>
6263
) : (
@@ -76,7 +77,7 @@ export const MainMediaGallery = ({
7677
role={mainMedia.role}
7778
format={format}
7879
elementId={mainMedia.elementId}
79-
isMainMedia={false}
80+
isMainMedia={true}
8081
position={mainMedia.position}
8182
/>
8283
)}

0 commit comments

Comments
 (0)