Skip to content

Commit 113b81c

Browse files
committed
Fix StickyBottomBanner to dispatch 'banner:none' event only when no banner is rendered - adding logic inside of useEffect before returning to prevent lint error
1 parent 6bf2fad commit 113b81c

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

dotcom-rendering/src/components/StickyBottomBanner.importable.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -402,17 +402,18 @@ export const StickyBottomBanner = ({
402402
isInAuxiaControlGroup,
403403
]);
404404

405+
useEffect(() => {
406+
if (SelectedBanner == null) {
407+
document.dispatchEvent(
408+
new CustomEvent('banner:none', {
409+
detail: { readerRevenue: false },
410+
}),
411+
);
412+
}
413+
}, [SelectedBanner]);
405414
if (SelectedBanner) {
406415
return <SelectedBanner />;
407416
}
408417

409-
useEffect(() => {
410-
document.dispatchEvent(
411-
new CustomEvent('banner:none', {
412-
detail: { readerRevenue: false },
413-
}),
414-
);
415-
});
416-
417418
return null;
418419
};

0 commit comments

Comments
 (0)