Migrate AB Testing scripts to node (#14837)

Author: Jakeii

.github/workflows/ab-testing-checks.yml

@@ -30,19 +30,26 @@ jobs:
     steps:
       - uses: actions/checkout@v5
 
-      # https://github.com/denoland/setup-deno#latest-stable-for-a-major
-      - uses: denoland/setup-deno@v1
-        with:
-          deno-version: v2.3
+      - name: Set up Node environment
+        uses: ./.github/actions/setup-node-env
 
       - name: Test
-        run: deno test
+        run: pnpm test
+
+      - name: Lint
+        run: pnpm lint
+
+      - name: Prettier Check
+        run: pnpm prettier:check
+
+      - name: Typecheck
+        run: pnpm tsc
 
       - name: Validate
-        run: deno run scripts/validation/index.ts
+        run: pnpm validate
 
       - name: Build
-        run: deno task build
+        run: pnpm build
 
       - if: ${{ inputs.save_build_artifact }}
         uses: actions/upload-artifact@v5

.github/workflows/ab-testing-deploy.yml

@@ -26,10 +26,8 @@ jobs:
     steps:
       - uses: actions/checkout@v5
 
-      # https://github.com/denoland/setup-deno#latest-stable-for-a-major
-      - uses: denoland/setup-deno@v1
-        with:
-          deno-version: v2.3
+      - name: Set up Node environment
+        uses: ./.github/actions/setup-node-env
 
       - name: Download build artifact
         uses: actions/download-artifact@v6.0.0
@@ -38,7 +36,7 @@ jobs:
           path: ab-testing/dist
 
       - name: Deploy
-        run: deno run deploy
+        run: pnpm run deploy
         env:
           FASTLY_AB_TESTING_CONFIG: ${{ secrets.FASTLY_AB_TESTING_CONFIG }}
           FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}

.github/workflows/ab-testing-ui.yml

@@ -1,4 +1,4 @@
-name: 🦕 AB testing UI
+name: 🧪 AB testing UI
 on:
   pull_request:
     paths:
@@ -15,22 +15,20 @@ jobs:
   build-ui:
     name: AB testing UI build
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
     defaults:
       run:
         working-directory: ab-testing/frontend
+    permissions:
+      contents: read
     steps:
       - uses: actions/checkout@v5
 
-      # https://github.com/denoland/setup-deno#latest-stable-for-a-major
-      - uses: denoland/setup-deno@v1
-        with:
-          deno-version: v2.3
-      - name: Install
-        run: deno install
-      - name: Build
-        run: deno run build
+      - name: Set up Node environment
+        uses: ./.github/actions/setup-node-env
+
+      - name: Build UI
+        run: pnpm build
+
       - name: Save build
         uses: actions/upload-artifact@v5
         with:
@@ -41,6 +39,7 @@ jobs:
   riff-raff:
     name: AB testing Riffraff upload
     runs-on: ubuntu-latest
+    needs: build-ui
     permissions:
       id-token: write
       contents: read

.vscode/settings.json.required

@@ -2,7 +2,7 @@
 // Copy these to .vscode/settings.json to apply them to your editor – but don't commit it!
 // https://github.com/guardian/recommendations/blob/main/VSCode.md#do-not-commit-vscode
 {
-	"deno.enablePaths": ["scripts/deno", "ab-testing/scripts"],
+	"deno.enablePaths": ["scripts/deno"],
 	"deno.lint": true,
 	"deno.unstable": false,
 	"typescript.tsdk": "node_modules/typescript/lib",

ab-testing/.prettierignore

@@ -0,0 +1 @@
+frontend/.svelte-kit

ab-testing/.prettierrc

@@ -0,0 +1 @@
+{}

ab-testing/abTest.ts ab-testing/abTests.tsab-testing/abTest.ts renamed to ab-testing/abTests.ts

@@ -1,4 +1,4 @@
-import type { ABTest } from './types';
+import type { ABTest } from "./types.ts";
 
 /**
  * Tests are defined here. They will be assigned mvt ranges based on the
@@ -21,18 +21,18 @@ import type { ABTest } from './types';
 
 const ABTests: ABTest[] = [
 	{
-		name: 'commercial-prebid-v10',
-		description: 'Testing Prebid.js v10 integration on DCR',
-		owners: ['commercial.dev@guardian.co.uk'],
-		status: 'ON',
-		expirationDate: '2025-12-30',
-		type: 'client',
+		name: "commercial-prebid-v10",
+		description: "Testing Prebid.js v10 integration on DCR",
+		owners: ["commercial.dev@guardian.co.uk"],
+		status: "ON",
+		expirationDate: "2025-12-30",
+		type: "client",
 		audienceSize: 0 / 100,
-		groups: ['control', 'variant'],
+		groups: ["control", "variant"],
 		shouldForceMetricsCollection: true,
 	},
 ];
 
-const activeABtests = ABTests.filter((test) => test.status === 'ON');
+const activeABtests = ABTests.filter((test) => test.status === "ON");
 
 export { ABTests as allABTests, activeABtests };

ab-testing/deno.json

@@ -0,0 +1,44 @@
+import guardian from "@guardian/eslint-config";
+import { defineConfig, globalIgnores } from "eslint/config";
+
+export default defineConfig([
+	globalIgnores(["frontend", "eslint.config.mjs", "index.ts"]),
+	...guardian.configs.recommended,
+	{
+		languageOptions: {
+			parserOptions: {
+				project: ["./tsconfig.json"],
+				tsconfigRootDir: "./",
+			},
+		},
+		rules: {
+			curly: ["error", "multi-line"],
+			"no-use-before-define": [
+				"error",
+				{ functions: true, classes: true },
+			],
+			"import/exports-last": "error",
+			"no-else-return": "error",
+		},
+	},
+	{
+		files: ["**/*.test.ts"],
+		rules: {
+			"@typescript-eslint/no-floating-promises": [
+				"off",
+				{
+					allowForKnownSafeCalls: [
+						{
+							from: "package",
+							name: ["it", "describe"],
+							package: "node:test",
+						},
+					],
+				},
+			],
+			"@typescript-eslint/unbound-method": "off",
+			// Allowing async tests without await for mocking convenience
+			"@typescript-eslint/require-await": "off",
+		},
+	},
+]);