Merge branch 'main' into gl/sc-tag-page-mockup

Author: Georges-GNM

.github/workflows/cicd.yml

@@ -2,9 +2,6 @@ name: DCR CICD
 
 on:
   push:
-    paths-ignore:
-      - 'ab-testing/**'
-      - '!ab-testing/config/abTests.ts'
 
 jobs:
   container:

ab-testing/config/abTests.ts

@@ -37,26 +37,14 @@ const ABTests: ABTest[] = [
 		description:
 			"Tests whether we can get the users email, hash it and pass pd value to the userId array",
 		owners: ["[email protected]"],
-		expirationDate: `2025-12-19`,
+		expirationDate: `2026-01-15`,
 		type: "client",
-		status: "ON",
+		status: "OFF",
 		audienceSize: 10 / 100,
 		audienceSpace: "A",
 		groups: ["control", "variant"],
 		shouldForceMetricsCollection: true,
 	},
-	{
-		name: "thefilter-product-element",
-		description:
-			"A hold back test to measure uplift of the product element",
-		owners: ["[email protected]"],
-		status: "ON",
-		expirationDate: "2025-12-30",
-		type: "server",
-		audienceSize: 40 / 100,
-		groups: ["control", "variant"],
-		shouldForceMetricsCollection: false,
-	},
 	{
 		name: "commercial-user-module-uid2",
 		description:

ab-testing/config/scripts/validation/validExpiration.test.ts

@@ -6,10 +6,10 @@ export function allExpirationsValid(tests: ABTest[]): boolean {
 		const now = new Date();
 
 		if (expires < now) {
-			throw new Error(
+			console.warn(
 				`${
 					test.name
-				} has an expiration date in the past: ${expires.toISOString()}, has it expired? If it doesn't belong to you or your team, you can set the status to OFF for now.`,
+				} has an expiration date in the past: ${expires.toISOString()}, has it expired?`,
 			);
 		}
 	});

ab-testing/config/scripts/validation/validExpiration.ts

@@ -0,0 +1,147 @@
+import { type FootballTable } from '../../src/footballTables';
+
+export const table: FootballTable = {
+	entries: [
+		{
+			position: 1,
+			team: {
+				name: 'Liverpool',
+				id: '9',
+				url: '/football/liverpool',
+			},
+			gamesPlayed: 29,
+			won: 21,
+			drawn: 7,
+			lost: 1,
+			goalsFor: 69,
+			goalsAgainst: 27,
+			goalDifference: 42,
+			points: 70,
+			results: [
+				{
+					matchId: '1',
+					self: { name: 'Liverpool', score: 1 },
+					foe: { name: 'Chelsea', score: 0 },
+				},
+				{
+					matchId: '2',
+					self: { name: 'Liverpool', score: 3 },
+					foe: { name: 'Arsenal', score: 5 },
+				},
+				{
+					matchId: '3',
+					self: { name: 'Liverpool', score: 0 },
+					foe: { name: 'West Ham', score: 0 },
+				},
+				{
+					matchId: '4',
+					self: { name: 'Liverpool', score: 8 },
+					foe: { name: 'Tottenham', score: 10 },
+				},
+				{
+					matchId: '5',
+					self: { name: 'Liverpool', score: 0 },
+					foe: { name: 'Brighton', score: 0 },
+				},
+			],
+		},
+		{
+			position: 2,
+			team: {
+				name: 'Arsenal',
+				id: '1006',
+				url: '/football/arsenal',
+			},
+			gamesPlayed: 29,
+			won: 21,
+			drawn: 10,
+			lost: 3,
+			goalsFor: 53,
+			goalsAgainst: 24,
+			goalDifference: 29,
+			points: 58,
+			results: [
+				{
+					matchId: '1',
+					self: { name: 'Arsenal', score: 4 },
+					foe: { name: 'Brighton', score: 0 },
+				},
+				{
+					matchId: '2',
+					self: { name: 'Arsenal', score: 3 },
+					foe: {
+						name: 'Manchester United',
+						score: 0,
+					},
+				},
+				{
+					matchId: '3',
+					self: { name: 'Arsenal', score: 5 },
+					foe: { name: 'West Ham', score: 0 },
+				},
+				{
+					matchId: '4',
+					self: { name: 'Arsenal', score: 9 },
+					foe: {
+						name: 'Manchester City',
+						score: 0,
+					},
+				},
+				{
+					matchId: '5',
+					self: { name: 'Arsenal', score: 0 },
+					foe: { name: 'Tottenham', score: 0 },
+				},
+			],
+		},
+		{
+			position: 3,
+			team: {
+				name: 'Nottm Forest',
+				id: '15',
+				url: '/football/nottinghamforest',
+			},
+			gamesPlayed: 29,
+			won: 16,
+			drawn: 6,
+			lost: 7,
+			goalsFor: 49,
+			goalsAgainst: 35,
+			goalDifference: 14,
+			points: 54,
+			results: [
+				{
+					matchId: '1',
+					self: { name: 'Nottm Forest', score: 4 },
+					foe: { name: 'Brighton', score: 4 },
+				},
+				{
+					matchId: '2',
+					self: { name: 'Nottm Forest', score: 0 },
+					foe: {
+						name: 'Manchester United',
+						score: 0,
+					},
+				},
+				{
+					matchId: '3',
+					self: { name: 'Nottm Forest', score: 0 },
+					foe: { name: 'West Ham', score: 7 },
+				},
+				{
+					matchId: '4',
+					self: { name: 'Nottm Forest', score: 9 },
+					foe: {
+						name: 'Manchester City',
+						score: 0,
+					},
+				},
+				{
+					matchId: '5',
+					self: { name: 'Nottm Forest', score: 10 },
+					foe: { name: 'Tottenham', score: 0 },
+				},
+			],
+		},
+	],
+};