Merge branch 'main' into doml/subtitles

Author: abeddow91

.github/CODEOWNERS

@@ -27,3 +27,4 @@
 /dotcom-rendering/src/lib/braze/                @guardian/value
 /dotcom-rendering/webpack/                      @guardian/dotcom-platform
 /scripts/                                       @guardian/dotcom-platform
+/ab-testing/                                    @guardian/commercial-dev

.github/workflows/ab-testing-checks.yml

@@ -20,6 +20,7 @@ on:
 jobs:
   checks:
     runs-on: ubuntu-latest
+    name: Checks
     defaults:
       run:
         working-directory: ab-testing

…hub/workflows/ab-testing-deploy-code.yml .github/workflows/ab-testing-ci-code.yml.github/workflows/ab-testing-deploy-code.yml renamed to .github/workflows/ab-testing-ci-code.yml .github/workflows/ab-testing-deploy-code.yml renamed to .github/workflows/ab-testing-ci-code.yml

@@ -1,4 +1,4 @@
-name: 🧪 Deploy CODE AB Testing Config
+name: 🧪 AB testing CI (CODE)
 
 permissions:
   contents: read

.github/workflows/ab-testing-ci.yml

@@ -7,10 +7,31 @@ on:
   pull_request:
     paths:
       - 'ab-testing/**'
+      - '.github/workflows/ab-testing-*.yml'
+  push:
+    branches:
+      - main
+    paths:
+      - 'ab-testing/**'
+      - '.github/workflows/ab-testing-*.yml'
 
 jobs:
-  checks:
+  ci:
+    name: CI
     uses: ./.github/workflows/ab-testing-checks.yml
+    with:
+      save_build_artifact: true
+    secrets:
+      FASTLY_AB_TESTING_CONFIG: ${{ secrets.FASTLY_PROD_AB_TESTING_CONFIG }}
+      FASTLY_API_TOKEN: ${{ secrets.FASTLY_PROD_API_TOKEN }}
+
+  deploy:
+    name: Deploy
+    needs: ci
+    if: github.ref == 'refs/heads/main'
+    uses: ./.github/workflows/ab-testing-deploy.yml
+    with:
+      stage: prod
     secrets:
-      FASTLY_AB_TESTING_CONFIG: ${{ secrets.FASTLY_CODE_AB_TESTING_CONFIG }}
-      FASTLY_API_TOKEN: ${{ secrets.FASTLY_CODE_API_TOKEN }}
+      FASTLY_AB_TESTING_CONFIG: ${{ secrets.FASTLY_PROD_AB_TESTING_CONFIG }}
+      FASTLY_API_TOKEN: ${{ secrets.FASTLY_PROD_API_TOKEN }}

.github/workflows/ab-testing-deploy-prod.yml

@@ -3,11 +3,13 @@ on:
   pull_request:
     paths:
       - 'ab-testing/**'
+      - '.github/workflows/ab-testing-*.yml'
   push:
     branches:
       - main
     paths:
       - 'ab-testing/**'
+      - '.github/workflows/ab-testing-*.yml'
 
 jobs:
   build-ui:

.github/workflows/ab-testing-ui.yml

@@ -63,6 +63,10 @@ To add a test where there is not enough space in the default audience space (`A`
 
 For example if there are already 3 25% tests in space `A` totalling 75%, and you want to run a 50% test, you can set the `audienceSpace` to `B` to allow this test to overlap with the existing tests.
 
+### Test Status
+
+Tests can be set to `ON` or `OFF` using the `status` field. Only tests with status `ON` will be validated and deployed.
+
 ## How it works
 
 The AB testing framework uses Deno to run scripts that validate and deploy the tests. The `deno.json` file contains the tasks that can be run, such as `validate`, `deploy`, and `build`.

ab-testing/README.md

@@ -19,4 +19,8 @@ import type { ABTest } from './types';
  * - 100% Test	variant		MVT 500-999
  */
 
-export const ABTests: ABTest[] = [];
+const ABTests: ABTest[] = [];
+
+const activeABtests = ABTests.filter((test) => test.status === 'ON');
+
+export { ABTests as allABTests, activeABtests };

ab-testing/abTest.ts

@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { ABTests } from '../../../abTest';
+	import { allABTests, activeABtests } from '../../../abTest';
 	import Table from '$lib/components/TableFixed.svelte';
 	import AudienceBreakdown from '$lib/components/AudienceBreakdown.svelte';
 </script>
@@ -31,8 +31,8 @@
 	</p>
 </section>
 <section>
-	<AudienceBreakdown tests={ABTests} />
-	<Table tests={ABTests} />
+	<AudienceBreakdown tests={activeABtests} />
+	<Table tests={allABTests} />
 </section>
 
 <style>

ab-testing/frontend/src/routes/+page.svelte

@@ -1,4 +1,3 @@
-// @ts-ignore - extension is required to import this as a package in DCR
-import { ABTests } from './abTest.ts';
+import { allABTests, activeABtests } from './abTest';
 
-export { ABTests };
+export { allABTests, activeABtests };