Skip to content

Commit 1ea583d

Browse files
Merge branch 'main' into 642-cache-for-newsletter-subscriptions-data
2 parents e41c19d + e624608 commit 1ea583d

File tree

4 files changed

+2
-52
lines changed

4 files changed

+2
-52
lines changed

.github/workflows/cicd.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: DCR CICD
22

33
on:
44
push:
5-
paths-ignore:
6-
- 'ab-testing/**'
7-
- '!ab-testing/config/abTests.ts'
85

96
jobs:
107
container:

ab-testing/config/scripts/validation/validExpiration.test.ts

Lines changed: 0 additions & 46 deletions
This file was deleted.

ab-testing/config/scripts/validation/validExpiration.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ export function allExpirationsValid(tests: ABTest[]): boolean {
66
const now = new Date();
77

88
if (expires < now) {
9-
throw new Error(
9+
console.warn(
1010
`${
1111
test.name
12-
} has an expiration date in the past: ${expires.toISOString()}, has it expired? If it doesn't belong to you or your team, you can set the status to OFF for now.`,
12+
} has an expiration date in the past: ${expires.toISOString()}, has it expired?`,
1313
);
1414
}
1515
});

dotcom-rendering/src/components/Contributor.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ const galleryBylineStyles = css`
3535
a {
3636
font-style: italic;
3737
:hover {
38-
text-decoration: underline;
3938
border-color: ${schemedPalette('--byline-anchor')};
4039
}
4140
}

0 commit comments

Comments
 (0)