Skip to content

Commit 22e88e0

Browse files
committed
In NoBoosts AB test, render boosted non-splash cards as non-boosted in Flexible General
1 parent 52278ca commit 22e88e0

File tree

3 files changed

+22
-2
lines changed

3 files changed

+22
-2
lines changed

dotcom-rendering/src/components/DecideContainer.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ type Props = {
4848
frontId?: string;
4949
collectionId: number;
5050
containerLevel?: DCRContainerLevel;
51+
isInNoBoostsAbTestVariant?: boolean;
5152
};
5253

5354
export const DecideContainer = ({
@@ -63,6 +64,7 @@ export const DecideContainer = ({
6364
frontId,
6465
collectionId,
6566
containerLevel,
67+
isInNoBoostsAbTestVariant,
6668
}: Props) => {
6769
switch (containerType) {
6870
case 'dynamic/fast':
@@ -268,6 +270,7 @@ export const DecideContainer = ({
268270
aspectRatio={aspectRatio}
269271
containerLevel={containerLevel}
270272
collectionId={collectionId}
273+
isInNoBoostsAbTestVariant={isInNoBoostsAbTestVariant}
271274
/>
272275
);
273276
case 'scrollable/small':

dotcom-rendering/src/components/FlexibleGeneral.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ type Props = {
3232
aspectRatio: AspectRatio;
3333
containerLevel?: DCRContainerLevel;
3434
collectionId: number;
35+
isInNoBoostsAbTestVariant?: boolean;
3536
};
3637

3738
type RowLayout = 'oneCardHalfWidth' | 'oneCardFullWidth' | 'twoCard';
@@ -580,17 +581,23 @@ export const FlexibleGeneral = ({
580581
aspectRatio,
581582
containerLevel = 'Primary',
582583
collectionId,
584+
isInNoBoostsAbTestVariant,
583585
}: Props) => {
584586
const splash = [...groupedTrails.splash].slice(0, 1).map((snap) => ({
585587
...snap,
586588
uniqueId: `collection-${collectionId}-splash-0`,
587589
}));
590+
588591
const cards = [...groupedTrails.standard]
589592
.slice(0, 19)
590593
.map((standard, i) => ({
591594
...standard,
595+
boostLevel: isInNoBoostsAbTestVariant
596+
? 'default'
597+
: standard.boostLevel,
592598
uniqueId: `collection-${collectionId}-standard-${i}`,
593599
}));
600+
594601
const groupedCards = decideCardPositions(cards);
595602

596603
return (

dotcom-rendering/src/layouts/FrontLayout.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,12 @@ const decideLeftContent = (front: Front, collection: DCRCollectionType) => {
105105

106106
export const FrontLayout = ({ front, NAV }: Props) => {
107107
const {
108-
config: { isPaidContent, hasPageSkin: hasPageSkinConfig, pageId },
108+
config: {
109+
isPaidContent,
110+
hasPageSkin: hasPageSkinConfig,
111+
pageId,
112+
abTests,
113+
},
109114
editionId,
110115
} = front;
111116

@@ -136,6 +141,8 @@ export const FrontLayout = ({ front, NAV }: Props) => {
136141

137142
const { absoluteServerTimes = false } = front.config.switches;
138143

144+
const isInNoBoostsVariant = abTests.noBoostsVariant === 'variant';
145+
139146
const fallbackAspectRatio = (collectionType: DCRContainerType) => {
140147
switch (collectionType) {
141148
case 'scrollable/feature':
@@ -199,7 +206,7 @@ export const FrontLayout = ({ front, NAV }: Props) => {
199206
'--article-section-background',
200207
)}
201208
>
202-
<HeaderAdSlot abTests={front.config.abTests} />
209+
<HeaderAdSlot abTests={abTests} />
203210
</Section>
204211
</Stuck>
205212
)}
@@ -743,6 +750,9 @@ export const FrontLayout = ({ front, NAV }: Props) => {
743750
sectionId={ophanName}
744751
collectionId={index + 1}
745752
containerLevel={collection.containerLevel}
753+
isInNoBoostsAbTestVariant={
754+
isInNoBoostsVariant
755+
}
746756
/>
747757
</FrontSection>
748758

0 commit comments

Comments
 (0)