Skip to content

Commit 27bfc7f

Browse files
committed
more riff-raff tweaks
1 parent 18755d3 commit 27bfc7f

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

.github/workflows/ab-testing-ci.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,17 @@ jobs:
7272
- name: Build Lambda
7373
run: pnpm build
7474

75+
- name: Zip app artifact
76+
run: |
77+
cd dist
78+
zip -r lambda.zip .
79+
zip -j lambda.zip ../package.json
80+
7581
- name: Save build
7682
uses: actions/upload-artifact@v5
7783
with:
7884
name: ab-testing-lambda-build
79-
path: ab-testing/dictionary-deploy-lambda/dist
85+
path: ab-testing/dictionary-deploy-lambda/dist/lambda.zip
8086

8187
ui-ci:
8288
name: UI CI
@@ -139,7 +145,7 @@ jobs:
139145
uses: actions/[email protected]
140146
with:
141147
name: ab-testing-lambda-build
142-
path: ab-testing/dictionary-deploy-lambda/dist
148+
path: ab-testing/dictionary-deploy-lambda/dist/lambda.zip
143149

144150
- name: CDK Test
145151
run: pnpm cdk:test
@@ -155,10 +161,10 @@ jobs:
155161
projectName: dotcom:ab-testing
156162
configPath: ab-testing/cdk.out/riff-raff.yaml
157163
contentDirectories: |
158-
ab-testing:
164+
ab-testing-config-artifacts:
159165
- ab-testing/dist
160-
ab-testing-dictionary-deploy-lambda:
161-
- ab-testing/dictionary-deploy-lambda/dist
166+
dictionary-deploy-lambda:
167+
- ab-testing/dictionary-deploy-lambda/dist/lambda.zip
162168
admin/ab-testing:
163169
- ab-testing/frontend/output/ab-tests.html
164170
cdk.out:

ab-testing/cdk/bin/cdk.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,23 @@ const {
3030
riffRaffYaml: { deployments },
3131
} = riffRaff;
3232

33-
const abTestingArtifactDeployment = "ab-testing-dictionary-artifact";
33+
const abTestingArtifactDeployment = "ab-testing-config-artifacts";
3434

3535
deployments.set(abTestingArtifactDeployment, {
3636
app: abTestingArtifactDeployment,
37-
contentDirectory: "dictionary-deploy-lambda/artifacts",
37+
contentDirectory: "ab-testing-config-artifacts",
3838
type: "aws-s3",
3939
regions: new Set(["eu-west-1"]),
4040
stacks: new Set(["frontend"]),
4141
parameters: {
4242
bucketSsmKey: "/account/services/dotcom-store.bucket",
4343
cacheControl: "public, max-age=315360000",
44+
prefixApp: false,
4445
prefixStack: false,
46+
prefixPackage: false,
47+
prefixStage: true,
4548
publicReadAcl: false,
49+
pathPrefixResource: "config/ab-tests",
4650
},
4751
});
4852

@@ -61,7 +65,7 @@ deployments.set("ab-testing-ui-artifact", {
6165
});
6266

6367
deployments
64-
.get(`lambda-update-eu-west-1-frontend-${appName}`)
68+
.get(`cfn-eu-west-1-frontend-dictionary-deploy-lambda`)
6569
?.dependencies?.push(abTestingArtifactDeployment);
6670

6771
riffRaff.synth();

0 commit comments

Comments
 (0)