Skip to content

Commit 2a255f2

Browse files
committed
drop references to carrot slot
1 parent e1eef0e commit 2a255f2

File tree

5 files changed

+8
-27
lines changed

5 files changed

+8
-27
lines changed

dotcom-rendering/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"@guardian/bridget": "8.7.0",
3333
"@guardian/browserslist-config": "6.1.0",
3434
"@guardian/cdk": "62.0.1",
35-
"@guardian/commercial-core": "28.0.0",
35+
"@guardian/commercial-core": "29.0.0",
3636
"@guardian/core-web-vitals": "7.0.0",
3737
"@guardian/eslint-config-typescript": "11.0.0",
3838
"@guardian/identity-auth": "6.0.1",

dotcom-rendering/playwright/tests/commercial.e2e.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ test.describe('Commercial E2E tests', () => {
1313
await cmpAcceptAll(page);
1414

1515
const fixedSlots = [
16-
'carrot', // Not used often, likely to be unfilled
1716
'right',
1817
'merchandising-high',
1918
'mostpop',

dotcom-rendering/src/components/AdSlot.web.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ type SlotNamesWithPageSkin = SlotName | 'pageskin';
3131

3232
type ServerRenderedSlot = Exclude<
3333
SlotNamesWithPageSkin,
34-
| 'carrot'
3534
| 'comments-expanded'
3635
| 'crossword-banner'
3736
| 'exclusion'

dotcom-rendering/src/lib/adStyles.ts

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { css } from '@emotion/react';
22
import { adSizes, constants } from '@guardian/commercial-core';
3-
import { from, space, textSans12, until } from '@guardian/source/foundations';
3+
import { from, textSans12, until } from '@guardian/source/foundations';
44
import { palette } from '../palette';
55

66
const labelHeight = constants.AD_LABEL_HEIGHT;
@@ -217,23 +217,6 @@ const spacefinderAdSlotStyles = css`
217217
}
218218
}
219219
220-
.ad-slot--carrot {
221-
float: left;
222-
clear: both;
223-
width: 140px;
224-
margin-right: 20px;
225-
margin-bottom: ${space[1]}px;
226-
${from.leftCol} {
227-
position: relative;
228-
margin-left: -160px;
229-
width: 140px;
230-
}
231-
${from.wide} {
232-
margin-left: -240px;
233-
width: 220px;
234-
}
235-
}
236-
237220
/* Scroll for more label on interscrollers */
238221
.ad-slot__scroll {
239222
position: fixed;

pnpm-lock.yaml

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)