Skip to content

Commit 2a9f7c4

Browse files
authored
Remove product element AB test (#15026)
1 parent 38d2c62 commit 2a9f7c4

File tree

2 files changed

+2
-27
lines changed

2 files changed

+2
-27
lines changed

ab-testing/config/abTests.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,6 @@ const ABTests: ABTest[] = [
4545
groups: ["control", "variant"],
4646
shouldForceMetricsCollection: true,
4747
},
48-
{
49-
name: "thefilter-product-element",
50-
description:
51-
"A hold back test to measure uplift of the product element",
52-
owners: ["[email protected]"],
53-
status: "ON",
54-
expirationDate: "2025-12-30",
55-
type: "server",
56-
audienceSize: 40 / 100,
57-
groups: ["control", "variant"],
58-
shouldForceMetricsCollection: false,
59-
},
6048
{
6149
name: "commercial-user-module-uid2",
6250
description:

dotcom-rendering/src/components/ProductElement.tsx

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import type { ReactNode } from 'react';
44
import type { ArticleFormat } from '../lib/articleFormat';
55
import { parseHtml } from '../lib/domUtils';
66
import type { NestedArticleElement } from '../lib/renderElement';
7-
import { useBetaAB } from '../lib/useAB';
87
import type { ProductBlockElement } from '../types/content';
98
import { ProductCardInline } from './ProductCardInline';
109
import { ProductCardLeftCol } from './ProductCardLeftCol';
@@ -40,32 +39,20 @@ export const ProductElement = ({
4039
format: ArticleFormat;
4140
shouldShowLeftColCard: boolean;
4241
}) => {
43-
const abTests = useBetaAB();
44-
const isInHoldBackTestVariant =
45-
abTests?.isUserInTestGroup('thefilter-product-element', 'variant') ??
46-
false;
47-
4842
const showContent =
4943
product.displayType === 'InlineOnly' ||
5044
product.displayType === 'InlineWithProductCard';
51-
// In the hold back test variant, if the product element has a display type of ProductCardOnly,
52-
// we should still render the product card. This is because there may not be any suitable
53-
// nested content to render, which could result in some unintended display issues. For the
54-
// InlineWithProductCard display type, we won't render the cards in the hold back test.
5545
const showProductCard =
5646
product.displayType === 'ProductCardOnly' ||
57-
(!isInHoldBackTestVariant &&
58-
product.displayType === 'InlineWithProductCard');
47+
product.displayType === 'InlineWithProductCard';
5948
return (
6049
<>
6150
{showContent && (
6251
<Content
6352
product={product}
6453
format={format}
6554
ArticleElementComponent={ArticleElementComponent}
66-
shouldShowLeftColCard={
67-
shouldShowLeftColCard && !isInHoldBackTestVariant
68-
}
55+
shouldShowLeftColCard={shouldShowLeftColCard}
6956
/>
7057
)}
7158
{showProductCard && (

0 commit comments

Comments
 (0)