Merge pull request #13822 from guardian/doml/europe-test-remove-ad-1-mobile

Remove top ad on mobile beta fronts

Author: domlander

dotcom-rendering/src/lib/getFrontsAdPositions.test.ts

@@ -218,7 +218,7 @@ describe('Mobile Ads', () => {
 
 	it('Europe Network Front, with beta containers and more than 4 collections, with thrashers in various places', () => {
 		const testCollections: AdCandidateMobile[] = [
-			{ collectionType: 'flexible/general', containerLevel: 'Primary' }, // Ad position (0)
+			{ collectionType: 'flexible/general', containerLevel: 'Primary' }, // Ignored - is before secondary container
 			{ collectionType: 'scrollable/small', containerLevel: 'Secondary' }, // Ignored - is before secondary container
 			{ collectionType: 'scrollable/small', containerLevel: 'Secondary' }, // Ignored - is before secondary container
 			{
@@ -262,7 +262,7 @@ describe('Mobile Ads', () => {
 
 		const mobileAdPositions = getMobileAdPositions(testCollections);
 
-		expect(mobileAdPositions).toEqual([0, 4, 6, 8, 13, 18]);
+		expect(mobileAdPositions).toEqual([4, 6, 8, 13, 18]);
 	});
 });
 

dotcom-rendering/src/lib/getFrontsAdPositions.ts

@@ -109,9 +109,8 @@ const canInsertMobileAd =
 
 		/** Additional rules exist for "beta" fronts which have primary and secondary level containers */
 		const betaFrontRules = [
-			// Allow insertion after first container at any time but for all other situations,
-			// prevent insertion before a secondary level container
-			index === 0 || !isBeforeSecondaryLevelContainer(index, collections),
+			// Prevent insertion before a secondary level container
+			!isBeforeSecondaryLevelContainer(index, collections),
 			// Prevent insertion before a branded container
 			!isBeforeBrandedContainer(index, collections),
 		];