Skip to content

Commit 30847c6

Browse files
committed
Merge branch 'main' into rjr-fix-video-main-media-poster-images
2 parents 8efd164 + 41a4263 commit 30847c6

File tree

13 files changed

+986
-356
lines changed

13 files changed

+986
-356
lines changed

.github/dependabot.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@ updates:
1010
schedule:
1111
interval: 'daily'
1212
ignore:
13-
# The version of the aws-cdk[-lib] & constructs dependencies should match
14-
# exactly the version specified by @guardian/cdk
15-
- dependency-name: 'aws-cdk'
16-
- dependency-name: 'aws-cdk-lib'
17-
- dependency-name: 'constructs'
1813
# The `check-node-versions` script enforces that this package is kept in
1914
# sync with our Node major version, so we want dependabot to ignore major
2015
# version updates, but still allow smaller updates.
@@ -29,6 +24,12 @@ updates:
2924
babel:
3025
patterns:
3126
- '*babel*'
27+
cdk:
28+
patterns:
29+
- '@guardian/cdk'
30+
- 'aws-cdk'
31+
- 'aws-cdk-lib'
32+
- 'constructs'
3233
eslint:
3334
patterns:
3435
- '*eslint*'

dotcom-rendering/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@
4646
"@guardian/support-dotcom-components": "7.7.0",
4747
"@guardian/tsconfig": "0.2.0",
4848
"@playwright/test": "1.52.0",
49-
"@sentry/browser": "7.75.1",
50-
"@sentry/integrations": "7.75.1",
49+
"@sentry/browser": "10.3.0",
5150
"@storybook/addon-essentials": "8.6.14",
5251
"@storybook/addon-interactions": "8.6.14",
5352
"@storybook/addon-webpack5-compiler-swc": "3.0.0",

dotcom-rendering/src/client/sentryLoader/sentry.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import * as Sentry from '@sentry/browser';
22
import type { BrowserOptions } from '@sentry/browser';
3-
import { CaptureConsole } from '@sentry/integrations';
43
import { BUILD_VARIANT, dcrJavascriptBundle } from '../../../webpack/bundles';
54
import type { ReportError } from '../../types/sentry';
65

@@ -44,7 +43,7 @@ Sentry.init({
4443
allowUrls,
4544
dsn: dcrSentryDsn,
4645
environment: stage || 'DEV',
47-
integrations: [new CaptureConsole({ levels: ['error'] })],
46+
integrations: [Sentry.captureConsoleIntegration({ levels: ['error'] })],
4847
maxBreadcrumbs: 50,
4948
// sampleRate: // We use Math.random in init.ts to sample errors
5049
});

dotcom-rendering/src/components/FollowWrapper.importable.tsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,15 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
2626
const isMyGuardianEnabled = useIsMyGuardianEnabled();
2727
const isBridgetCompatible = useIsBridgetCompatible('2.5.0');
2828

29-
isBridgetCompatible && isMyGuardianEnabled && setShowFollowTagButton(true);
29+
const isNotInBlockList = (tagId: string) => {
30+
const blockList = ['profile/anas-al-sharif'];
31+
return !blockList.includes(tagId);
32+
};
33+
34+
isBridgetCompatible &&
35+
isMyGuardianEnabled &&
36+
isNotInBlockList(id) &&
37+
setShowFollowTagButton(true);
3038

3139
useEffect(() => {
3240
const topic = new Topic({

dotcom-rendering/src/components/ScrollableHighlights.stories.tsx

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { breakpoints } from '@guardian/source/foundations';
12
import type { Meta, StoryObj } from '@storybook/react';
23
import { defaultCard, trails } from '../../fixtures/manual/highlights-trails';
34
import { ScrollableHighlights } from './ScrollableHighlights.importable';
@@ -6,6 +7,16 @@ import { Section } from './Section';
67
const meta: Meta<typeof ScrollableHighlights> = {
78
title: 'Components/Masthead/ScrollableHighlights',
89
component: ScrollableHighlights,
10+
parameters: {
11+
chromatic: {
12+
viewports: [
13+
breakpoints.mobile,
14+
breakpoints.mobileLandscape,
15+
breakpoints.tablet,
16+
breakpoints.wide,
17+
],
18+
},
19+
},
920
render: ({ ...args }) => (
1021
<Section
1122
shouldCenter={true}

dotcom-rendering/src/components/marketing/banners/common/BannerWrapper.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ function getComponentIds(bannerId: BannerId) {
4949
reminderCta: `${bannerId} : reminder-cta`,
5050
reminderSet: `${bannerId} : reminder-set`,
5151
reminderClose: `${bannerId} : reminder-close`,
52+
collapse: `${bannerId} : collapse`,
53+
expand: `${bannerId} : expand`,
5254
};
5355
}
5456

@@ -298,6 +300,8 @@ const withBannerData =
298300
const onCloseClick = clickHandlerFor(componentIds.close, true);
299301
const onNotNowClick = clickHandlerFor(componentIds.notNow, true);
300302
const onSignInClick = clickHandlerFor(componentIds.signIn, false);
303+
const onCollapseClick = clickHandlerFor(componentIds.collapse, false);
304+
const onExpandClick = clickHandlerFor(componentIds.expand, false);
301305

302306
try {
303307
const renderedContent = content && buildRenderedContent(content);
@@ -316,6 +320,8 @@ const withBannerData =
316320
onCloseClick,
317321
onSignInClick,
318322
onNotNowClick,
323+
onCollapseClick,
324+
onExpandClick,
319325
content: {
320326
mainContent: renderedContent,
321327
mobileContent: renderedMobileContent ?? renderedContent,

dotcom-rendering/src/components/marketing/banners/common/types.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ export interface BannerRenderProps {
6363
onNotNowClick: () => void;
6464
onCloseClick: () => void;
6565
onSignInClick?: () => void;
66+
onCollapseClick: () => void;
67+
onExpandClick: () => void;
6668
reminderTracking: ContributionsReminderTracking;
6769
content: BannerTextContent;
6870
countryCode?: string;

0 commit comments

Comments
 (0)