Skip to content

Commit 3291f94

Browse files
author
“LAKSHMIRPILLAI”
committed
Changes to support configurable goal copy
1 parent 33e280f commit 3291f94

File tree

9 files changed

+130
-166
lines changed

9 files changed

+130
-166
lines changed

dotcom-rendering/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@
5353
"@guardian/react-crossword-next": "npm:@guardian/[email protected]",
5454
"@guardian/shimport": "1.0.2",
5555
"@guardian/source": "9.0.0",
56-
"@guardian/source-development-kitchen": "17.0.0",
57-
"@guardian/support-dotcom-components": "6.2.0",
56+
"@guardian/source-development-kitchen": "18.1.0",
57+
"@guardian/support-dotcom-components": "6.3.0",
5858
"@guardian/tsconfig": "0.2.0",
5959
"@playwright/test": "1.45.3",
6060
"@sentry/browser": "7.75.1",

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
347347
copy={{
348348
headline:
349349
tickerSettings.copy.countLabel,
350+
goalCopy: tickerSettings.copy.goalCopy,
350351
}}
351352
tickerData={tickerSettings.tickerData}
352353
tickerStylingSettings={

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBannerV2.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,7 @@ const DesignableBannerV2: ReactComponent<BannerRenderProps> = ({
376376
copy={{
377377
headline:
378378
tickerSettings.copy.countLabel,
379+
goalCopy: tickerSettings.copy.goalCopy,
379380
}}
380381
tickerData={tickerSettings.tickerData}
381382
tickerStylingSettings={

dotcom-rendering/src/components/marketing/banners/designableBanner/stories/DesignableBanner.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ const tickerSettings: TickerSettings = {
5454
currencySymbol: '£',
5555
copy: {
5656
countLabel: '',
57+
goalCopy: 'goal',
5758
},
5859
tickerData: {
5960
total: 500000,

dotcom-rendering/src/components/marketing/epics/ContributionsEpic.stories.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ export const WithTicker: Story = {
197197
currencySymbol: '£',
198198
copy: {
199199
countLabel: 'Help us reach our end-of-year goal',
200+
goalCopy: 'goal',
200201
},
201202
tickerData: {
202203
total: 10000,
@@ -221,6 +222,7 @@ export const WithTickerAndWithAboveTopReaderArticleCount: Story = {
221222
currencySymbol: '£',
222223
copy: {
223224
countLabel: 'Help us reach our end-of-year goal',
225+
goalCopy: 'goal',
224226
},
225227
tickerData: {
226228
total: 10000,

dotcom-rendering/src/components/marketing/epics/ContributionsEpic.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,7 @@ const ContributionsEpic: ReactComponent<EpicProps> = ({
367367
currencySymbol={tickerSettings.currencySymbol}
368368
copy={{
369369
headline: tickerSettings.copy.countLabel,
370+
goalCopy: tickerSettings.copy.goalCopy,
370371
}}
371372
tickerData={tickerSettings.tickerData}
372373
tickerStylingSettings={defaultTickerStylingSettings}

dotcom-rendering/src/components/marketing/epics/ContributionsLiveblogEpic.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ export const WithTicker: Story = {
113113
currencySymbol: '£',
114114
copy: {
115115
countLabel: 'Help us reach our end-of-year goal',
116+
goalCopy: 'goal',
116117
},
117118
tickerData: {
118119
total: 10000,

dotcom-rendering/src/components/marketing/epics/ContributionsLiveblogEpic.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ export const ContributionsLiveblogEpic: ReactComponent<EpicProps> = ({
201201
currencySymbol={tickerSettings.currencySymbol}
202202
copy={{
203203
headline: tickerSettings.copy.countLabel,
204+
goalCopy: tickerSettings.copy.goalCopy,
204205
}}
205206
tickerData={tickerSettings.tickerData}
206207
tickerStylingSettings={defaultTickerStylingSettings}

0 commit comments

Comments
 (0)