Skip to content

Commit 34e0e9d

Browse files
author
Juarez Mota
committed
refactor: simplify collapse and expand click handlers in DesignableBanner
1 parent 89b5471 commit 34e0e9d

File tree

1 file changed

+23
-29
lines changed

1 file changed

+23
-29
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 23 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,9 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
188188
const handleSetIsCollapsed = (collapsed: boolean) => {
189189
setIsCollapsed(collapsed);
190190
if (collapsed) {
191-
if (typeof onCollapseClick === 'function') {
192-
(onCollapseClick as () => void)();
193-
}
191+
onCollapseClick();
194192
} else {
195-
if (typeof onExpandClick === 'function') {
196-
(onExpandClick as () => void)();
197-
}
193+
onExpandClick();
198194
}
199195
};
200196

@@ -419,30 +415,28 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
419415
)}
420416

421417
{!selectedChoiceCard && (
422-
<>
423-
<div css={styles.outerImageCtaContainer}>
424-
<div css={styles.innerImageCtaContainer}>
425-
<DesignableBannerCtas
426-
mainOrMobileContent={mainOrMobileContent}
427-
onPrimaryCtaClick={onCtaClick}
428-
onSecondaryCtaClick={onSecondaryCtaClick}
429-
primaryCtaSettings={
430-
templateSettings.primaryCtaSettings
431-
}
432-
secondaryCtaSettings={
433-
templateSettings.secondaryCtaSettings
434-
}
435-
onCloseClick={
436-
isMaybeLaterVariant &&
437-
isCollapsed &&
438-
typeof onCloseClick === 'function'
439-
? onCloseClick
440-
: undefined
441-
}
442-
/>
443-
</div>
418+
<div css={styles.outerImageCtaContainer}>
419+
<div css={styles.innerImageCtaContainer}>
420+
<DesignableBannerCtas
421+
mainOrMobileContent={mainOrMobileContent}
422+
onPrimaryCtaClick={onCtaClick}
423+
onSecondaryCtaClick={onSecondaryCtaClick}
424+
primaryCtaSettings={
425+
templateSettings.primaryCtaSettings
426+
}
427+
secondaryCtaSettings={
428+
templateSettings.secondaryCtaSettings
429+
}
430+
onCloseClick={
431+
isMaybeLaterVariant &&
432+
isCollapsed &&
433+
typeof onCloseClick === 'function'
434+
? onCloseClick
435+
: undefined
436+
}
437+
/>
444438
</div>
445-
</>
439+
</div>
446440
)}
447441

448442
<div

0 commit comments

Comments
 (0)