Skip to content

Commit 361ebe3

Browse files
committed
Refactor for better performance and property naming
1 parent bf29a4f commit 361ebe3

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

dotcom-rendering/src/layouts/GalleryLayout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ export const GalleryLayout = (props: WebProps | AppProps) => {
292292
) : null}
293293
</div>
294294
</header>
295-
{gallery.images.map((element, index) => {
295+
{gallery.bodyElements.map((element, index) => {
296296
const isImage =
297297
element._type ===
298298
'model.dotcomrendering.pageElements.ImageBlockElement';

dotcom-rendering/src/model/enhance-ad-placeholders.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,13 @@ const insertAdPlaceholdersForGallery = (elements: FEElement[]): FEElement[] => {
106106

107107
const shouldInsertAd = imageBlockElementCounter % 4 === 0;
108108

109-
const currentElements = [...prev.elements, currentElement];
110-
111109
return {
112110
elements: shouldInsertAd
113111
? insertPlaceholderAfterCurrentElement(
114112
prev.elements,
115113
currentElement,
116114
)
117-
: currentElements,
115+
: [...prev.elements, currentElement],
118116
imageBlockElementCounter,
119117
};
120118
},

dotcom-rendering/src/types/article.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export type ArticleFields = {
4545

4646
export type Gallery = ArticleFields & {
4747
design: ArticleDesign.Gallery;
48-
images: (ImageBlockElement | AdPlaceholderBlockElement)[];
48+
bodyElements: (ImageBlockElement | AdPlaceholderBlockElement)[];
4949
mainMedia: ImageBlockElement;
5050
};
5151

@@ -135,7 +135,7 @@ export const enhanceArticleType = (
135135
design,
136136
display: format.display,
137137
theme: format.theme,
138-
images: blocks.flatMap((block) =>
138+
bodyElements: blocks.flatMap((block) =>
139139
block.elements.filter(
140140
(element) =>
141141
element._type ===

0 commit comments

Comments
 (0)