Prefer alternative over dark when referring to the second theme for star ratings.

This is to prevent overloading the term dark which is more commonly used in the code base to refer to dark mode

Author: abeddow91

dotcom-rendering/src/components/FeatureCard.tsx

@@ -645,7 +645,7 @@ export const FeatureCard = ({
 												<StarRating
 													rating={starRating}
 													size={starRatingSize}
-													useDarkTheme={true}
+													useAlternativeTheme={true}
 												/>
 											) : (
 												<div css={starRatingWrapper}>

dotcom-rendering/src/components/StarRating/StarRating.stories.tsx

@@ -1,5 +1,4 @@
 import type { Meta, StoryObj } from '@storybook/react-webpack5';
-
 import { type Props, StarRating } from './StarRating';
 
 const meta = {
@@ -61,9 +60,9 @@ export const StarsWithLargePadding: Story = {
 	},
 };
 
-export const StarsWithDarkTheme: Story = {
+export const StarsWithAlternativeTheme: Story = {
 	args: {
 		size: 'large',
-		useDarkTheme: true,
+		useAlternativeTheme: true,
 	},
 };

dotcom-rendering/src/components/StarRating/StarRating.tsx

@@ -23,8 +23,8 @@ const emptyStarColor = css`
 	background-color: ${palette('--star-rating-empty-background')};
 `;
 
-const emptyStarDarkColor = css`
-	background-color: ${palette('--star-rating-empty-dark-background')};
+const emptyStarAltColor = css`
+	background-color: ${palette('--star-rating-empty-alt-background')};
 `;
 
 const determineSize = (size: RatingSizeType) => {
@@ -108,15 +108,19 @@ export type Props = {
 	rating: Rating;
 	size: RatingSizeType;
 	paddingSize?: PaddingSizeType;
-	/** The dark theme is to account for star ratings that appear on lighter / translucent backgrounds (eg feature cards). The dark theme ensures we meet AA accessibility standard*/
-	useDarkTheme?: boolean;
+	/**
+	 * The alternative theme is to account for star ratings that appear on
+	 *  lighter / translucent backgrounds (e.g. feature cards).
+	 *  The alternative theme ensures we meet AA accessibility standards.
+	 */
+	useAlternativeTheme?: boolean;
 };
 
 export const StarRating = ({
 	rating,
 	size,
 	paddingSize = 'small',
-	useDarkTheme = false,
+	useAlternativeTheme = false,
 }: Props) => (
 	<div
 		css={[determineSize(size), determinePaddingTop(paddingSize), container]}
@@ -131,7 +135,9 @@ export const StarRating = ({
 					key={i}
 					css={[
 						starBackground,
-						useDarkTheme ? emptyStarDarkColor : emptyStarColor,
+						useAlternativeTheme
+							? emptyStarAltColor
+							: emptyStarColor,
 					]}
 				>
 					<SvgStarOutline />

dotcom-rendering/src/paletteDeclarations.ts

@@ -7963,12 +7963,12 @@ const paletteColours = {
 		light: starRatingBackgroundColourLight,
 		dark: starRatingBackgroundColourDark,
 	},
-	'--star-rating-empty-background': {
-		light: starRatingEmptyBackgroundColourLight,
+	'--star-rating-empty-alt-background': {
+		light: starRatingEmptyBackgroundColourDark,
 		dark: starRatingEmptyBackgroundColourDark,
 	},
-	'--star-rating-empty-dark-background': {
-		light: starRatingEmptyBackgroundColourDark,
+	'--star-rating-empty-background': {
+		light: starRatingEmptyBackgroundColourLight,
 		dark: starRatingEmptyBackgroundColourDark,
 	},
 	'--star-rating-fill': {