Merge pull request #13575 from guardian/tf-auxia-pending

Refactor auxia isSignedIn check

Author: tomrf1

dotcom-rendering/src/components/SignInGateSelector.importable.tsx

@@ -6,6 +6,7 @@ import {
 } from '../lib/contributions';
 import { getDailyArticleCount, getToday } from '../lib/dailyArticleCount';
 import type { EditionId } from '../lib/edition';
+import { isUserLoggedInOktaRefactor } from '../lib/identity';
 import { parseCheckoutCompleteCookieData } from '../lib/parser/parseCheckoutOutCookieData';
 import { constructQuery } from '../lib/querystring';
 import { useAB } from '../lib/useAB';
@@ -650,12 +651,6 @@ const SignInGateSelectorAuxia = ({
 		This function if the Auxia prototype for the SignInGateSelector component.
 	*/
 
-	const authStatus = useAuthStatus();
-
-	const isSignedIn =
-		authStatus.kind === 'SignedInWithOkta' ||
-		authStatus.kind === 'SignedInWithCookies';
-
 	const [isGateDismissed, setIsGateDismissed] = useState<boolean | undefined>(
 		undefined,
 	);
@@ -689,11 +684,13 @@ const SignInGateSelectorAuxia = ({
 
 	useOnce(() => {
 		void (async () => {
+			// Only make a request to Auxia if user is signed out. This means signed-in users will never receive an Auxia treatment, and therefore never see a sign-in gate
+			const isSignedIn = await isUserLoggedInOktaRefactor();
+
 			// Although the component is returning null if we are in preview or it's a paid content
 			// We need to guard against the API possibly being called before the component returns.
 			// That is because it would count as a content delivery for them, above all if they return a treatment
 			//  without the subsequent Log Treatment notification, which would cause confusion.
-
 			if (!isSignedIn && !isPreview && !isPaidContent) {
 				const data = await buildAuxiaGateDisplayData(
 					contributionsServiceUrl,
@@ -730,15 +727,15 @@ const SignInGateSelectorAuxia = ({
 		})().catch((error) => {
 			console.error('Error fetching Auxia display data:', error);
 		});
-	}, [abTest, isSignedIn, isPaidContent, isPreview]);
+	}, [abTest, isPaidContent, isPreview]);
 
 	// We are not showing the gate if we are in preview, it's a paid contents
 	// or the user is signed in or if for some reasons we could not determine the
 	// pageViewId
 
 	// According to the reacts rules we can only put this check after all the hooks.
 
-	if (isPreview || isPaidContent || isSignedIn || isUndefined(pageViewId)) {
+	if (isPreview || isPaidContent || isUndefined(pageViewId)) {
 		return null;
 	}