use human-readable function name for lambda

Author: cemms1

ab-testing/cdk/lib/__snapshots__/notificationLambda.test.ts.snap

@@ -317,6 +317,7 @@ exports[`The AB testing notification lambda stack > matches the CODE snapshot 1`
             "APP": "ab-testing-notification-lambda"
           }
         },
+        "FunctionName": "ABTestingNotifications-CODE",
         "Handler": "index.handler",
         "LoggingConfig": {
           "LogFormat": "JSON"
@@ -827,6 +828,7 @@ exports[`The AB testing notification lambda stack > matches the PROD snapshot 1`
             "APP": "ab-testing-notification-lambda"
           }
         },
+        "FunctionName": "ABTestingNotifications-PROD",
         "Handler": "index.handler",
         "LoggingConfig": {
           "LogFormat": "JSON"

ab-testing/cdk/lib/notificationLambda.ts

@@ -10,7 +10,7 @@ import { Effect, PolicyStatement } from "aws-cdk-lib/aws-iam";
 import { Runtime } from "aws-cdk-lib/aws-lambda";
 import { Subscription, SubscriptionProtocol, Topic } from "aws-cdk-lib/aws-sns";
 
-const lambdaFunctionName = "ab-testing-notification-lambda";
+const appName = "ab-testing-notification-lambda";
 
 const getEmailDomain = (stage: GuStackProps["stage"]) => {
 	switch (stage) {
@@ -33,7 +33,7 @@ export class AbTestingNotificationLambda extends GuStack {
 		};
 
 		const emailIdentity = new GuEmailIdentity(this, "EmailIdentity", {
-			app: lambdaFunctionName,
+			app: appName,
 			domainName: getEmailDomain(props.stage),
 		});
 
@@ -53,7 +53,8 @@ export class AbTestingNotificationLambda extends GuStack {
 			this,
 			"AbTestingNotificationLambda",
 			{
-				app: lambdaFunctionName,
+				functionName: `ABTestingNotifications-${props.stage}`,
+				app: appName,
 				fileName: "lambda.zip",
 				handler: "index.handler",
 				rules: this.stage === "PROD" ? [runDailyRule] : [],