validate test size and offset

Author: Jakeii

ab-testing/scripts/validation/index.ts

@@ -2,6 +2,7 @@ import { ABTests } from '../../abTest.ts';
 import { ABTest } from '../../types.ts';
 import { limitServerSideTests } from './limitServerSide.ts';
 import { allExpirationsValid } from './validExpiration.ts';
+import { validSizeOffset } from './validSizeOffset.ts';
 import { noVariantOverlap } from './variantOverlap.ts';
 
 type ValidationFunction = (tests: ABTest[]) => boolean;
@@ -10,6 +11,7 @@ const rules: ValidationFunction[] = [
 	noVariantOverlap,
 	limitServerSideTests,
 	allExpirationsValid,
+	validSizeOffset,
 ];
 
 function validateTests(testList: ABTest[]) {

ab-testing/scripts/validation/validSizeOffset.test.ts

@@ -0,0 +1,55 @@
+import { assertThrows, assertEquals } from 'jsr:@std/assert';
+import { ABTest } from '../../types.ts';
+import { validSizeOffset } from './validSizeOffset.ts';
+
+const baseTest: ABTest = {
+	name: 'commercial-future',
+	description: 'End on a weekday',
+	owners: ['[email protected]'],
+	status: 'ON',
+	expirationDate: new Date(),
+	type: 'client',
+	highImpact: false,
+	audienceSize: 10 / 100,
+	groups: ['control', 'variant'],
+};
+Deno.test(
+	'validSizeOffset - passes when audienceSize is between 0 and 1',
+	() => {
+		const test: ABTest = {
+			...baseTest,
+			audienceSize: 0.5,
+		};
+
+		assertEquals(validSizeOffset([test]), true);
+	},
+);
+
+Deno.test('validSizeOffset - throws when audienceSize is less than 0', () => {
+	const test: ABTest = {
+		...baseTest,
+		audienceSize: -0.1,
+	};
+
+	assertThrows(
+		() => validSizeOffset([test]),
+		Error,
+		`Invalid audienceSize for test ${test.name}`,
+	);
+});
+
+Deno.test(
+	'validSizeOffset - throws when audienceSize is greater than 1',
+	() => {
+		const test: ABTest = {
+			...baseTest,
+			audienceSize: 1.1,
+		};
+
+		assertThrows(
+			() => validSizeOffset([test]),
+			Error,
+			`Invalid audienceSize for test ${test.name}`,
+		);
+	},
+);

ab-testing/scripts/validation/validSizeOffset.ts

@@ -0,0 +1,30 @@
+import { ABTest } from '../../types.ts';
+
+const _validSizeOffset = (test: ABTest): boolean => {
+	// Check if audienceSize is defined and is a number between 0 and 1
+	if (
+		typeof test.audienceSize !== 'number' ||
+		test.audienceSize < 0 ||
+		test.audienceSize > 1
+	) {
+		throw new Error(`Invalid audienceSize for test ${test.name}`);
+	}
+
+	// Check if audienceOffset is defined and is a number between 0 and 1
+	if (
+		test.audienceOffset !== undefined &&
+		(typeof test.audienceOffset !== 'number' ||
+			test.audienceOffset < 0 ||
+			test.audienceOffset > 1)
+	) {
+		throw new Error(`Invalid audienceOffset for test ${test.name}`);
+	}
+
+	return true;
+};
+
+const validSizeOffset = (tests: ABTest[]): boolean => {
+	return tests.every(_validSizeOffset);
+};
+
+export { validSizeOffset };