Skip to content

Commit 4a77541

Browse files
author
sookburt
committed
fix style lint issues
1 parent 05d4ef3 commit 4a77541

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/components/DesignableBannerHeader.tsx

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,12 @@ export function DesignableBannerHeader({
4040
isCollapsed = false,
4141
}: DesignableBannerHeaderProps): JSX.Element {
4242
const isTabletOrAbove = useMatchMedia(removeMediaRulePrefix(from.tablet));
43-
const styles = getStyles(headerSettings, headlineSize);
43+
const styles = getStyles(
44+
headerSettings,
45+
headlineSize,
46+
isInABTestVariant,
47+
isCollapsed,
48+
);
4449

4550
const resolveImage = (settings: Image) => {
4651
return (
@@ -60,7 +65,7 @@ export function DesignableBannerHeader({
6065

6166
return (
6267
<div css={styles.container}>
63-
<header css={styles.header(isInABTestVariant, isCollapsed)}>
68+
<header css={styles.header}>
6469
{headerSettings?.headerImage &&
6570
resolveImage(headerSettings.headerImage)}
6671
{(heading ?? mobileHeading) && resolveCopy()}
@@ -72,21 +77,34 @@ export function DesignableBannerHeader({
7277
const getStyles = (
7378
headerSettings: HeaderSettings | undefined,
7479
headlineSize: 'small' | 'medium' | 'large',
80+
isInABTestVariant: boolean,
81+
isCollapsed: boolean,
7582
) => {
7683
const color = headerSettings?.textColour ?? neutral[0];
7784
const copyTopMargin = headerSettings?.headerImage ? space[1] : space[1];
7885
const containerMargin = headerSettings?.headerImage ? `${space[6]}px` : '0';
86+
7987
const mobileHeadlineSize =
8088
headlineSize === 'small'
8189
? `${headlineMedium17}`
8290
: `${headlineMedium28}`;
8391

92+
const phabletHeadline =
93+
isInABTestVariant && isCollapsed
94+
? `${mobileHeadlineSize}`
95+
: `${headlineMedium34}`;
96+
97+
const leftColHeadline =
98+
isInABTestVariant && isCollapsed
99+
? `${mobileHeadlineSize}`
100+
: `${headlineMedium42}`;
101+
84102
return {
85103
container: css`
86104
position: relative;
87105
margin-bottom: ${containerMargin};
88106
`,
89-
header: (isInABTestVariant: boolean, isCollapsed: boolean) => css`
107+
header: css`
90108
h2 {
91109
color: ${color};
92110
margin: ${copyTopMargin}px 0 ${space[2]}px 0;
@@ -96,15 +114,11 @@ const getStyles = (
96114
}
97115
98116
${from.phablet} {
99-
{${
100-
isInABTestVariant && isCollapsed
101-
} ? ${mobileHeadlineSize} : ${headlineMedium34}}
117+
${phabletHeadline};
102118
}
103119
104120
${from.leftCol} {
105-
{${
106-
isInABTestVariant && isCollapsed
107-
} ? ${mobileHeadlineSize} : ${headlineMedium42}}
121+
${leftColHeadline};
108122
}
109123
}
110124
`,

0 commit comments

Comments
 (0)