Skip to content

Commit 4ffb79c

Browse files
committed
more frontend ui fixes
1 parent 509496f commit 4ffb79c

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

.github/workflows/ab-testing-deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
path: ab-testing/dist
3737

3838
- name: Deploy
39-
run: deno run deploy
39+
run: pnpm deploy
4040
env:
4141
FASTLY_AB_TESTING_CONFIG: ${{ secrets.FASTLY_AB_TESTING_CONFIG }}
4242
FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}

.github/workflows/ab-testing-ui.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,23 @@ jobs:
1515
build-ui:
1616
name: AB testing UI build
1717
runs-on: ubuntu-latest
18-
permissions:
19-
contents: read
2018
defaults:
2119
run:
22-
working-directory: ab-testing/frontend
20+
working-directory: ab-testing
21+
permissions:
22+
contents: read
2323
steps:
2424
- uses: actions/checkout@v5
2525

2626
- name: Set up Node environment
2727
uses: ./.github/actions/setup-node-env
2828

29-
- name: Install
30-
run: pnpm install --frozen-lockfile
31-
32-
- name: Build
29+
- name: Build AB Tests
3330
run: pnpm build
3431

32+
- name: Build UI
33+
run: pnpm build-ui
34+
3535
- name: Save build
3636
uses: actions/upload-artifact@v5
3737
with:

ab-testing/package.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,12 @@
33
"version": "1.0.0",
44
"description": "A/B test definitions and configuration",
55
"main": "index.ts",
6-
"module": "index.ts",
7-
"exports": {
8-
".": {
9-
"import": "./index.ts"
10-
}
11-
},
126
"type": "module",
137
"scripts": {
148
"validate": "node scripts/validation/index.ts",
159
"deploy": "node scripts/deploy/index.ts --mvts=dist/mvts.json --ab-tests=dist/ab-tests.json",
1610
"build": "node scripts/build/index.ts --mvts=dist/mvts.json --ab-tests=dist/ab-tests.json",
11+
"build-ui": "pnpm --filter @guardian/ab-testing-frontend run build",
1712
"test": "node --test",
1813
"lint": "eslint .",
1914
"prettier:check": "prettier . --check --cache",

0 commit comments

Comments
 (0)