Skip to content

Commit 55413ee

Browse files
JamieB-guarelra
andauthored
Narrow dotcom-platform In CODEOWNERS (#13734)
When a person or team is marked as a code owner for an area of the codebase, they are automatically requested for review whenever a PR modifies that area. At the moment, dotcom-platform is marked as a code owner for almost the entire codebase. This means that they receive a review request for essentially every PR that's opened. This change alters the dotcom-platform team's entry in the CODEOWNERS file to target specific areas of the codebase. Note that this does not prevent PR authors from requesting reviews from dotcom-platform, or anyone else, as needed. It just narrows the list of PRs for which the team is asked for review automatically. Also specifies Commercial as the owners of some files. Co-authored-by: Ravi <[email protected]>
1 parent 960e9f5 commit 55413ee

File tree

1 file changed

+23
-4
lines changed

1 file changed

+23
-4
lines changed

.github/CODEOWNERS

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,27 @@
11
# This file is matched from top down; subsequent matches override previous matches.
22
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
33

4-
# By default all files are owned by these teams:
5-
* @guardian/dotcom-platform
4+
# Files at the root of the project
5+
/* @guardian/dotcom-platform
66

7-
/dotcom-rendering/src/components/marketing/ @guardian/growth
8-
/dotcom-rendering/src/client/userFeatures/ @guardian/supporter-revenue-stream
7+
/.github/ @guardian/dotcom-platform
8+
/.husky/ @guardian/dotcom-platform
9+
/.vscode/ @guardian/dotcom-platform
10+
/apps-rendering/ @guardian/dotcom-platform
11+
12+
# Files at the root of `/dotcom-rendering`
13+
/dotcom-rendering/* @guardian/dotcom-platform
14+
15+
/dotcom-rendering/.storybook/ @guardian/dotcom-platform
16+
/dotcom-rendering/cdk/ @guardian/dotcom-platform
17+
/dotcom-rendering/configs/ @guardian/dotcom-platform
18+
/dotcom-rendering/scripts/ @guardian/dotcom-platform
19+
/dotcom-rendering/src/client/islands/ @guardian/dotcom-platform
20+
/dotcom-rendering/src/client/userFeatures/ @guardian/supporter-revenue-stream
21+
/dotcom-rendering/src/components/AdBlock* @guardian/commercial-dev
22+
/dotcom-rendering/src/components/AdSlot* @guardian/commercial-dev
23+
/dotcom-rendering/src/components/AdP* @guardian/commercial-dev
24+
/dotcom-rendering/src/components/marketing/ @guardian/growth
25+
/dotcom-rendering/src/server/ @guardian/dotcom-platform
26+
/dotcom-rendering/webpack/ @guardian/dotcom-platform
27+
/scripts/ @guardian/dotcom-platform

0 commit comments

Comments
 (0)