fix issues with audience offset

Author: i-hardy

.husky/pre-push

@@ -6,10 +6,11 @@ then
 	exit 1
 fi
 
+cd ./$(dirname "$0")/../dotcom-rendering
+make tsc
+
+
 if git diff-tree --no-commit-id --name-only -r HEAD..origin/$currentBranch | grep -q 'ab-testing/'; then
-  	cd ./$(dirname "$0")/../ab-testing
+  	cd ../ab-testing
 	deno test && deno run validate
 fi
-
-cd ./$(dirname "$0")/../dotcom-rendering
-make tsc

ab-testing/abTest.ts

@@ -40,8 +40,8 @@ export const ABTests: ABTest[] = [
 		status: 'ON',
 		expirationDate: new Date('2025-09-02'),
 		type: 'client',
-		audienceSize: 20 / 100,
-		audienceOffset: 10,
+		audienceSize: 10 / 100,
+		audienceOffset: 15 / 100,
 		groups: ['control', 'variant'],
 	},
 	// Example server side AB test definition
@@ -72,7 +72,7 @@ export const ABTests: ABTest[] = [
 		expirationDate: new Date('2025-08-04'),
 		type: 'server',
 		audienceSize: 10 / 100,
-		audienceOffset: 30,
+		audienceOffset: 30 / 100,
 		groups: ['control', 'variant'],
 	},
 	{
@@ -87,7 +87,7 @@ export const ABTests: ABTest[] = [
 		expirationDate: new Date('2025-08-04'),
 		type: 'server',
 		audienceSize: 10 / 100,
-		audienceOffset: 40,
+		audienceOffset: 45 / 100,
 		groups: ['control', 'variant'],
 	},
 ];

ab-testing/scripts/validation/validSizeOffset.test.ts

@@ -52,3 +52,33 @@ Deno.test(
 		);
 	},
 );
+
+Deno.test(
+	'validSizeOffset - passes when audienceOffset is between 0 and 1',
+	() => {
+		const test: ABTest = {
+			...baseTest,
+			audienceSize: 0.5,
+			audienceOffset: 0.1,
+		};
+
+		assertEquals(validSizeOffset([test]), true);
+	},
+);
+
+Deno.test(
+	'validSizeOffset - throws when audienceOffset is greater than 1',
+	() => {
+		const test: ABTest = {
+			...baseTest,
+			audienceSize: 0.5,
+			audienceOffset: 11,
+		};
+
+		assertThrows(
+			() => validSizeOffset([test]),
+			Error,
+			`Invalid audienceOffset for test ${test.name}`,
+		);
+	},
+);