Skip to content

Commit 5b5986a

Browse files
committed
remove unused import
1 parent b5c51fa commit 5b5986a

File tree

3 files changed

+27
-34
lines changed

3 files changed

+27
-34
lines changed

dotcom-rendering/src/components/Card/components/TrailText.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
space,
55
textSans14,
66
textSans17,
7-
textSans20,
87
} from '@guardian/source/foundations';
98
import { Hide } from '@guardian/source/react-components';
109
import { palette } from '../../../palette';

dotcom-rendering/src/components/StorylineSection.tsx

Lines changed: 25 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { css } from '@emotion/react';
22
import { between, from, space, until } from '@guardian/source/foundations';
3-
import { pageSkinContainer } from '../layouts/lib/pageSkin';
43
import { type EditionId, isNetworkFront } from '../lib/edition';
54
import { palette as schemePalette } from '../palette';
65
import type { CollectionBranding } from '../types/branding';
@@ -303,21 +302,21 @@ const sectionHeadlineUntilLeftCol = (isOpinion: boolean) => css`
303302
}
304303
`;
305304

306-
const sectionHeadlineFromLeftCol = (borderColour: string) => css`
307-
${from.leftCol} {
308-
position: relative;
309-
::after {
310-
content: '';
311-
display: block;
312-
width: 1px;
313-
top: 0;
314-
height: 1.875rem;
315-
right: -10px;
316-
position: absolute;
317-
background-color: ${borderColour};
318-
}
319-
}
320-
`;
305+
// const sectionHeadlineFromLeftCol = (borderColour: string) => css`
306+
// ${from.leftCol} {
307+
// position: relative;
308+
// ::after {
309+
// content: '';
310+
// display: block;
311+
// width: 1px;
312+
// top: 0;
313+
// height: 1.875rem;
314+
// right: -10px;
315+
// position: absolute;
316+
// background-color: ${borderColour};
317+
// }
318+
// }
319+
// `;
321320

322321
const topPadding = css`
323322
padding-top: ${space[2]}px;
@@ -585,15 +584,13 @@ export const StorylineSection = ({
585584
treats,
586585
url,
587586
pagination,
588-
hasPageSkin = false,
589587
collectionBranding,
590588
isTagPage = false,
591589
hasNavigationButtons = false,
592590
isAboveDesktopAd = false,
593591
isAboveMobileAd = false,
594592
}: Props) => {
595593
const isToggleable = toggleable && !!sectionId;
596-
const showVerticalRule = !hasPageSkin;
597594
const isBetaContainer = !!containerLevel;
598595

599596
// These are for beta containers only
@@ -618,12 +615,9 @@ export const StorylineSection = ({
618615
css={[
619616
fallbackStyles,
620617
containerStylesUntilLeftCol,
621-
!hasPageSkin && containerStylesFromLeftCol,
622-
!hasPageSkin &&
623-
hasNavigationButtons &&
618+
containerStylesFromLeftCol,
619+
hasNavigationButtons &&
624620
containerScrollableStylesFromLeftCol,
625-
626-
hasPageSkin && pageSkinContainer,
627621
]}
628622
>
629623
{isBetaContainer && showTopBorder && (
@@ -660,11 +654,11 @@ export const StorylineSection = ({
660654
// only ever having <CPScott> as the leftContent
661655
title?.toLowerCase() === 'opinion',
662656
),
663-
showVerticalRule &&
664-
!isBetaContainer &&
665-
sectionHeadlineFromLeftCol(
666-
schemePalette('--section-border'),
667-
),
657+
// showVerticalRule &&
658+
// !isBetaContainer &&
659+
// sectionHeadlineFromLeftCol(
660+
// schemePalette('--section-border'),
661+
// ),
668662
]}
669663
>
670664
<FrontSectionTitle
@@ -716,9 +710,8 @@ export const StorylineSection = ({
716710
sectionContentHorizontalMargins,
717711
sectionContentRow(toggleable),
718712
topPadding,
719-
showVerticalRule &&
720-
isBetaContainer &&
721-
sectionContentBorderFromLeftCol,
713+
// showVerticalRule &&
714+
isBetaContainer && sectionContentBorderFromLeftCol,
722715
]}
723716
id={`container-${sectionId}`}
724717
>
@@ -748,7 +741,7 @@ export const StorylineSection = ({
748741
)}
749742
</div>
750743

751-
{treats && !hasPageSkin && (
744+
{treats && (
752745
<div css={[sectionTreats]}>
753746
<Treats
754747
treats={treats}

dotcom-rendering/src/components/StorylinesSection.importable.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { TagPage } from 'src/types/tagPage';
2-
import { from } from '@guardian/source/foundations';
32
import { css } from '@emotion/react';
43
import { useState } from 'react';
54
import { DCRFrontCard, DCRGroupedTrails, TreatType } from 'src/types/front';
@@ -18,6 +17,7 @@ type Storyline = {
1817
categories: Category[];
1918
};
2019

20+
// probably want to add a generic category type mapping to those in supercharger (e.g. opinions) and map this to a container type and title (e.g. "Contrasting Opinions" + "flexible/general")
2121
export type Category = {
2222
title: string;
2323
containerType: string;
@@ -625,6 +625,7 @@ export const StorylinesSection = ({
625625
},
626626
];
627627

628+
//
628629
const testStorylines: Storyline[] = [
629630
{
630631
id: 'storyline-1',

0 commit comments

Comments
 (0)