Skip to content

Commit 5eb2450

Browse files
committed
reorganise some of the code and delete some of the unnecessary parts
1 parent 016ffda commit 5eb2450

File tree

6 files changed

+248
-343
lines changed

6 files changed

+248
-343
lines changed

dotcom-rendering/src/components/Card/Card.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,6 @@ export const Card = ({
740740

741741
return (
742742
<Hide from={isFlexSplash ? 'desktop' : 'tablet'}>
743-
<div>check</div>
744743
<Sublinks />
745744
</Hide>
746745
);

dotcom-rendering/src/components/FlexibleSpecial.tsx

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ type Props = {
3232
containerLevel?: DCRContainerLevel;
3333
collectionId: number;
3434
showLabsRedesign?: boolean;
35-
SCStyle?: boolean;
3635
};
3736

3837
type BoostProperties = {
@@ -55,20 +54,15 @@ const determineCardProperties = (
5554
supportingContentLength: number,
5655
mediaCard: boolean,
5756
imageSuppressed: boolean,
58-
SCStyle: boolean,
5957
): BoostProperties => {
6058
switch (boostLevel) {
6159
// The default boost level is equal to no boost. It is the same as the default card layout.
6260
case 'default':
6361
return {
6462
headlineSizes: {
65-
desktop: SCStyle
66-
? 'small'
67-
: imageSuppressed
68-
? 'xxlarge'
69-
: 'xlarge',
70-
tablet: SCStyle ? 'small' : 'large',
71-
mobile: SCStyle ? 'xxsmall' : 'medium',
63+
desktop: imageSuppressed ? 'xxlarge' : 'xlarge',
64+
tablet: 'large',
65+
mobile: 'medium',
7266
},
7367
mediaSize: 'xlarge',
7468
mediaPositionOnDesktop: 'right',
@@ -140,7 +134,6 @@ type OneCardLayoutProps = {
140134
containerLevel: DCRContainerLevel;
141135
isSplashCard?: boolean;
142136
showLabsRedesign?: boolean;
143-
SCStyle?: boolean;
144137
};
145138

146139
export const OneCardLayout = ({
@@ -155,7 +148,6 @@ export const OneCardLayout = ({
155148
containerLevel,
156149
isSplashCard,
157150
showLabsRedesign,
158-
SCStyle = false,
159151
}: OneCardLayoutProps) => {
160152
const card = cards[0];
161153
if (!card) return null;
@@ -174,7 +166,6 @@ export const OneCardLayout = ({
174166
card.supportingContent?.length ?? 0,
175167
isMediaCard(card.format),
176168
!card.image,
177-
SCStyle,
178169
);
179170

180171
return (
@@ -208,9 +199,7 @@ export const OneCardLayout = ({
208199
trailTextSize={trailTextSize}
209200
canPlayInline={true}
210201
showKickerImage={card.format.design === ArticleDesign.Audio}
211-
headlinePosition={
212-
SCStyle ? 'inner' : isSplashCard ? 'outer' : 'inner'
213-
}
202+
headlinePosition={isSplashCard ? 'outer' : 'inner'}
214203
showLabsRedesign={showLabsRedesign}
215204
subtitleSize={subtitleSize}
216205
/>
@@ -242,7 +231,6 @@ type TwoOrFourCardLayoutProps = {
242231
containerLevel: DCRContainerLevel;
243232
/** Feature flag for the labs redesign work */
244233
showLabsRedesign?: boolean;
245-
SCStyle: boolean;
246234
};
247235

248236
const TwoOrFourCardLayout = ({
@@ -256,13 +244,12 @@ const TwoOrFourCardLayout = ({
256244
isFirstRow,
257245
containerLevel,
258246
showLabsRedesign,
259-
SCStyle,
260247
}: TwoOrFourCardLayoutProps) => {
261248
if (cards.length === 0) return null;
262249
const hasTwoOrFewerCards = cards.length <= 2;
263250

264251
return (
265-
<UL direction="row" showTopBar={!SCStyle}>
252+
<UL direction="row" showTopBar={true}>
266253
{cards.map((card, cardIndex) => {
267254
return (
268255
<LI
@@ -318,7 +305,6 @@ export const FlexibleSpecial = ({
318305
containerLevel = 'Primary',
319306
collectionId,
320307
showLabsRedesign,
321-
SCStyle = false,
322308
}: Props) => {
323309
const snaps = [...groupedTrails.snap].slice(0, 1).map((snap) => ({
324310
...snap,
@@ -363,7 +349,6 @@ export const FlexibleSpecial = ({
363349
containerLevel={containerLevel}
364350
isSplashCard={true}
365351
showLabsRedesign={showLabsRedesign}
366-
SCStyle={SCStyle}
367352
/>
368353
)}
369354

@@ -377,7 +362,6 @@ export const FlexibleSpecial = ({
377362
isFirstRow={!isNonEmptyArray(snaps) && !isNonEmptyArray(splash)}
378363
containerLevel={containerLevel}
379364
showLabsRedesign={showLabsRedesign}
380-
SCStyle={SCStyle}
381365
/>
382366
</>
383367
);

dotcom-rendering/src/components/StorylineTabContent.tsx

Lines changed: 0 additions & 94 deletions
This file was deleted.

0 commit comments

Comments
 (0)