Skip to content

Commit 622fef9

Browse files
committed
Use column-gap instead of padding for flex splash
1 parent 85e13f6 commit 622fef9

File tree

2 files changed

+0
-21
lines changed

2 files changed

+0
-21
lines changed

dotcom-rendering/src/components/Card/Card.tsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -638,13 +638,6 @@ export const Card = ({
638638
};
639639
}
640640

641-
if (isFlexSplash) {
642-
return {
643-
row: 'small',
644-
column: 'none',
645-
};
646-
}
647-
648641
if (!isBetaContainer) {
649642
/**
650643
* Media cards have 4px padding around the content so we have a
@@ -1092,11 +1085,6 @@ export const Card = ({
10921085
isBetaContainer,
10931086
isOnwardContent,
10941087
)}
1095-
padRight={
1096-
!!isFlexSplash &&
1097-
image &&
1098-
imagePositionOnDesktop === 'right'
1099-
}
11001088
>
11011089
{/* This div is needed to keep the headline and trail text justified at the start */}
11021090
<div

dotcom-rendering/src/components/Card/components/ContentWrapper.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,6 @@ const paddingBetaContainerStyles = (
9999
}
100100
`;
101101

102-
const padRightStyles = css`
103-
${from.tablet} {
104-
padding-right: ${space[5]}px;
105-
}
106-
`;
107-
108102
const getImageDirection = (
109103
imagePosition: ImagePositionType,
110104
): ImageDirection => {
@@ -127,7 +121,6 @@ type Props = {
127121
imagePositionOnDesktop: ImagePositionType;
128122
imagePositionOnMobile: ImagePositionType;
129123
padContent?: 'small' | 'large';
130-
padRight?: boolean;
131124
};
132125

133126
export const ContentWrapper = ({
@@ -138,7 +131,6 @@ export const ContentWrapper = ({
138131
imagePositionOnDesktop,
139132
imagePositionOnMobile,
140133
padContent,
141-
padRight = false,
142134
}: Props) => {
143135
const imageDirectionDesktop = getImageDirection(imagePositionOnDesktop);
144136
const paddingSpace = padContent === 'small' ? 1 : 2;
@@ -161,7 +153,6 @@ export const ContentWrapper = ({
161153
imagePositionOnDesktop,
162154
paddingSpace,
163155
),
164-
padRight && padRightStyles,
165156
]}
166157
>
167158
{children}

0 commit comments

Comments
 (0)