Skip to content

Commit 653ce99

Browse files
authored
Merge pull request #14734 from guardian/jm/feat-tiny-banner-close-button
adjust heading spacing in designable banner
2 parents be7a2e9 + 32fac7f commit 653ce99

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
311311
isCollapsableBanner && isCollapsed
312312
? styles.collapsedLayoutOverrides(
313313
cardsImageOrSpaceTemplateString,
314+
isMaybeLaterVariant,
314315
)
315316
: styles.layoutOverrides(
316317
cardsImageOrSpaceTemplateString,
@@ -572,10 +573,10 @@ const styles = {
572573
padding: ${space[3]}px ${space[3]}px 0 ${space[3]}px;
573574
grid-template-columns: auto max(${phabletContentMaxWidth} auto);
574575
grid-template-areas:
575-
'. close-button .'
576-
'. copy-container .'
577-
'. ${cardsImageOrSpaceTemplateString} .'
578-
'. cta-container .';
576+
'. . .'
577+
'. copy-container close-button'
578+
'. ${cardsImageOrSpaceTemplateString} ${cardsImageOrSpaceTemplateString}'
579+
'. cta-container cta-container';
579580
}
580581
${from.phablet} {
581582
max-width: 740px;
@@ -623,7 +624,10 @@ const styles = {
623624
'. vert-line cta-container ${cardsImageOrSpaceTemplateString} .';
624625
}
625626
`,
626-
collapsedLayoutOverrides: (cardsImageOrSpaceTemplateString: string) => css`
627+
collapsedLayoutOverrides: (
628+
cardsImageOrSpaceTemplateString: string,
629+
isMaybeLaterVariant: boolean,
630+
) => css`
627631
display: grid;
628632
background: inherit;
629633
position: relative;
@@ -635,11 +639,19 @@ const styles = {
635639
margin: 0 auto;
636640
padding: ${space[2]}px ${space[3]}px 0 ${space[3]}px;
637641
grid-template-columns: auto max(${phabletContentMaxWidth} auto);
638-
grid-template-areas:
642+
grid-template-areas: ${isMaybeLaterVariant
643+
? `
644+
'. . .'
645+
'. copy-container close-button'
646+
'. ${cardsImageOrSpaceTemplateString} ${cardsImageOrSpaceTemplateString}'
647+
'. cta-container cta-container'
648+
`
649+
: `
639650
'. close-button .'
640651
'. copy-container .'
641652
'. ${cardsImageOrSpaceTemplateString} .'
642653
'. cta-container .';
654+
`};
643655
}
644656
${from.phablet} {
645657
max-width: 740px;
@@ -704,7 +716,7 @@ const styles = {
704716
/* Layout changes only here */
705717
grid-area: close-button;
706718
${until.phablet} {
707-
padding-right: ${space[2]}px;
719+
padding-bottom: ${space[4]}px;
708720
justify-self: end;
709721
position: sticky;
710722
top: 10px;

0 commit comments

Comments
 (0)