Merge pull request #14256 from guardian/doml/fallback-image

Looping video: Use a fallback image for replacement video

Author: domlander

dotcom-rendering/src/model/enhanceCards.ts

@@ -167,20 +167,23 @@ const getLargestImageUrl = (images?: Image[]) => {
 };
 
 /**
- * If we have a replacement video, we should use the largest available trail image from the media atom.
- * For all other videos, we should use the card's trail image where it is available and fall back to the media trail image.
- * */
+ * If we have a replacement video, we should prioritise the largest available trail image from the media atom.
+ * For all other videos, we should prioritise the card's trail image.
+ */
 const decideMediaAtomImage = (
 	videoReplace: boolean,
 	mediaAtom: FEMediaAtom,
 	cardTrailImage?: string,
 ) => {
+	const largestMediaAtomImage = getLargestImageUrl(
+		mediaAtom.trailImage?.allImages,
+	);
+
 	if (videoReplace) {
-		return getLargestImageUrl(mediaAtom.trailImage?.allImages);
+		return largestMediaAtomImage ?? cardTrailImage;
 	}
-	return (
-		cardTrailImage ?? getLargestImageUrl(mediaAtom.trailImage?.allImages)
-	);
+
+	return cardTrailImage ?? largestMediaAtomImage;
 };
 
 /**