Skip to content

Commit 68dbca3

Browse files
author
Juarez Mota
committed
feat: make log treatment action name optional
1 parent aa54163 commit 68dbca3

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxia.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const SignInGateAuxia = ({
102102
renderingTarget,
103103
abTest,
104104
);
105-
void logTreatmentInteractionCall('DISMISSED', '');
105+
void logTreatmentInteractionCall('DISMISSED');
106106
}}
107107
>
108108
{secondCtaName}

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV1.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export const SignInGateAuxiaV1 = ({
7575
renderingTarget,
7676
abTest,
7777
);
78-
void logTreatmentInteractionCall('DISMISSED', '');
78+
void logTreatmentInteractionCall('DISMISSED');
7979
}}
8080
>
8181
<SvgCross size="xsmall" />

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV2.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export const SignInGateAuxiaV2 = ({
7979
renderingTarget,
8080
abTest,
8181
);
82-
void logTreatmentInteractionCall('DISMISSED', '');
82+
void logTreatmentInteractionCall('DISMISSED');
8383
}
8484
};
8585

@@ -114,7 +114,7 @@ export const SignInGateAuxiaV2 = ({
114114
renderingTarget,
115115
abTest,
116116
);
117-
void logTreatmentInteractionCall('DISMISSED', '');
117+
void logTreatmentInteractionCall('DISMISSED');
118118
};
119119

120120
return (
@@ -154,7 +154,6 @@ export const SignInGateAuxiaV2 = ({
154154
);
155155
void logTreatmentInteractionCall(
156156
'DISMISSED',
157-
'',
158157
);
159158
}}
160159
>
@@ -200,7 +199,6 @@ export const SignInGateAuxiaV2 = ({
200199
);
201200
void logTreatmentInteractionCall(
202201
'DISMISSED',
203-
'',
204202
);
205203
}}
206204
>

dotcom-rendering/src/components/SignInGate/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ export type SignInGatePropsAuxia = {
243243
userTreatment: AuxiaAPIResponseDataUserTreatment;
244244
logTreatmentInteractionCall: (
245245
interactionType: AuxiaInteractionInteractionType,
246-
actionName: AuxiaInteractionActionName,
246+
actionName?: AuxiaInteractionActionName,
247247
) => Promise<void>;
248248
};
249249

dotcom-rendering/src/components/SignInGateSelector.importable.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ interface ShowSignInGateAuxiaProps {
156156
renderingTarget: RenderingTarget;
157157
logTreatmentInteractionCall: (
158158
interactionType: AuxiaInteractionInteractionType,
159-
actionName: AuxiaInteractionActionName,
159+
actionName?: AuxiaInteractionActionName,
160160
) => Promise<void>;
161161
signInGateVersion?: AuxiaGateVersion;
162162
}
@@ -351,13 +351,13 @@ const SignInGateSelectorAuxia = ({
351351
renderingTarget={renderingTarget}
352352
logTreatmentInteractionCall={async (
353353
interactionType: AuxiaInteractionInteractionType,
354-
actionName: AuxiaInteractionActionName,
354+
actionName?: AuxiaInteractionActionName,
355355
) => {
356356
await auxiaLogTreatmentInteraction(
357357
contributionsServiceUrl,
358358
auxiaGateDisplayData.auxiaData.userTreatment!,
359359
interactionType,
360-
actionName,
360+
actionName ?? '',
361361
auxiaGateDisplayData.browserId,
362362
).catch((error) => {
363363
const errorReport = new Error(

0 commit comments

Comments
 (0)