Merge pull request #14447 from guardian/ph-20250823-1630-gate-upgrades

clarify and ensure sign-in gate specs

Author: shtukas

dotcom-rendering/src/components/SignInGate/displayRules.ts

@@ -58,6 +58,18 @@ export const hasRequiredConsents = (): Promise<boolean> =>
 		.then(({ canTarget }: ConsentState) => canTarget)
 		.catch(() => false);
 
+export const pageMetaDataMakesItEligibleForGateDisplay = (
+	contentType: string,
+	sectionId: string | undefined,
+	tags: TagType[],
+): boolean => {
+	return (
+		isValidContentType(contentType) &&
+		isValidSection(sectionId) &&
+		isValidTag(tags)
+	);
+};
+
 export const canShowSignInGate = ({
 	isSignedIn,
 	currentTest,
@@ -66,23 +78,30 @@ export const canShowSignInGate = ({
 	tags,
 	isPaidContent,
 	isPreview,
-}: CanShowGateProps): Promise<boolean> =>
-	Promise.resolve(
+}: CanShowGateProps): Promise<boolean> => {
+	// This check is functionally identical to the same check in SDC
+	// This logically ensures that SDC will get a subset of the pages for which
+	// pageMetaDataMakesItEligibleForGateDisplay return true
+	if (
+		!pageMetaDataMakesItEligibleForGateDisplay(contentType, sectionId, tags)
+	) {
+		return Promise.resolve(false);
+	}
+
+	return Promise.resolve(
 		!isSignedIn &&
 			!hasUserDismissedGateMoreThanCount(
 				currentTest.variant,
 				currentTest.name,
 				5,
 			) &&
 			isNPageOrHigherPageView(3) &&
-			isValidContentType(contentType) &&
-			isValidSection(sectionId) &&
-			isValidTag(tags) &&
 			// hide the sign in gate on isPaidContent
 			!isPaidContent &&
 			// hide the sign in gate on internal tools preview &&
 			!isPreview,
 	);
+};
 
 export const canShowSignInGateMandatory: ({
 	isSignedIn,