Skip to content

Commit 73cade0

Browse files
authored
Merge branch 'main' into fix-image-width-for-gallery-inline-images
2 parents 019c08a + 512cafa commit 73cade0

File tree

8 files changed

+110
-134
lines changed

8 files changed

+110
-134
lines changed

.github/workflows/ar-chromatic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
- name: Chromatic - Apps Rendering
4040
env:
4141
NODE_OPTIONS: '--max_old_space_size=4096'
42-
uses: chromaui/action@v11.27.0
42+
uses: chromaui/action@v13.3.0
4343

4444
with:
4545
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN__APPS_RENDERING }}

.github/workflows/dcr-chromatic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Chromatic - DCR
3636
env:
3737
NODE_OPTIONS: '--max_old_space_size=4096'
38-
uses: chromaui/action@v11.27.0
38+
uses: chromaui/action@v13.3.0
3939
with:
4040
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN__DOTCOM_RENDERING }}
4141
token: ${{ secrets.GITHUB_TOKEN }}

dotcom-rendering/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@
3232
"@guardian/bridget": "8.7.0",
3333
"@guardian/browserslist-config": "6.1.0",
3434
"@guardian/cdk": "61.4.0",
35-
"@guardian/commercial-core": "27.1.0",
35+
"@guardian/commercial-core": "28.0.0",
3636
"@guardian/core-web-vitals": "7.0.0",
3737
"@guardian/eslint-config": "7.0.1",
3838
"@guardian/eslint-config-typescript": "9.0.1",
3939
"@guardian/identity-auth": "6.0.1",
4040
"@guardian/identity-auth-frontend": "8.1.0",
41-
"@guardian/libs": "25.3.0",
41+
"@guardian/libs": "26.0.0",
4242
"@guardian/ophan-tracker-js": "2.3.2",
4343
"@guardian/react-crossword": "6.3.0",
4444
"@guardian/shimport": "1.0.2",

dotcom-rendering/src/components/Caption.tsx

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,19 @@ const captionLink = css`
210210
}
211211
`;
212212

213+
const galleryCaptionHeadingReset = css`
214+
h2 {
215+
display: inline;
216+
font-weight: bold;
217+
}
218+
h2::after {
219+
content: '';
220+
display: block;
221+
}
222+
`;
223+
213224
const galleryStyles = css`
225+
${galleryCaptionHeadingReset}
214226
${grid.column.centre};
215227
${textSans14};
216228

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV2.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,7 @@ const headerSection = css`
407407
flex-direction: column-reverse;
408408
gap: ${space[6]}px;
409409
padding-right: ${space[4]}px;
410+
max-height: 528px;
410411
max-width: 100%;
411412
}
412413
`;

dotcom-rendering/src/server/htmlPageTemplate.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,18 @@ export const htmlPageTemplate = (props: WebProps | AppProps): string => {
7979
} = props;
8080

8181
const doNotIndex = (): boolean => {
82-
const isDevelopment = process.env.GU_STAGE !== 'PROD';
82+
if (process.env.GU_STAGE !== 'PROD') return true;
83+
if (!canonicalUrl) return false;
8384

84-
const hasNoIndexPattern = Boolean(
85-
canonicalUrl?.includes('tracking/commissioningdesk'),
86-
);
85+
const isAllowListed = [
86+
'tracking/commissioningdesk/the-filter',
87+
'tracking/commissioningdesk/filter-us',
88+
].some((allowed) => canonicalUrl.includes(allowed));
8789

88-
return isDevelopment || hasNoIndexPattern;
90+
return (
91+
canonicalUrl.includes('tracking/commissioningdesk') &&
92+
!isAllowListed
93+
);
8994
};
9095

9196
/**

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
},
2525
"dependencies": {
2626
"@guardian/prettier": "5.0.0",
27-
"chromatic": "11.27.0",
27+
"chromatic": "13.3.0",
2828
"husky": "9.1.7",
2929
"lint-staged": "15.2.0",
3030
"prettier": "3.0.3",

0 commit comments

Comments
 (0)