Skip to content

Commit 801de6f

Browse files
authored
Merge pull request #14703 from guardian/doml/remove-whole-picture-us
Remove Whole Picture logo
2 parents c282b15 + 3e3018d commit 801de6f

22 files changed

+4
-180
lines changed

dotcom-rendering/src/components/Masthead/Masthead.stories.tsx

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -50,30 +50,3 @@ export const WithPageSkin = {
5050
export const WithPageSkinAndContentSelfContstrain = {
5151
args: { hasPageSkinContentSelfConstrain: true },
5252
};
53-
54-
export const WithUsLogoAndWithoutSubnav = {
55-
args: { wholePictureLogoSwitch: true, editionId: 'US' },
56-
};
57-
58-
export const WithUsLogoAndSubnav = {
59-
args: { ...WithUsLogoAndWithoutSubnav.args, showSubNav: true },
60-
};
61-
62-
export const WithUsLogoAndSlimNav = {
63-
args: {
64-
...WithUsLogoAndWithoutSubnav.args,
65-
showSlimNav: true,
66-
displayRoundel: true,
67-
},
68-
};
69-
70-
export const WithUsLogoAndPageSkin = {
71-
args: { ...WithUsLogoAndWithoutSubnav.args, hasPageSkin: true },
72-
};
73-
74-
export const WithUsLogoAndPageSkinAndContentSelfContstrain = {
75-
args: {
76-
...WithUsLogoAndWithoutSubnav.args,
77-
hasPageSkinContentSelfConstrain: true,
78-
},
79-
};

dotcom-rendering/src/components/Masthead/Masthead.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ type Props = {
2222
hasPageSkin?: boolean;
2323
hasPageSkinContentSelfConstrain?: boolean;
2424
pageId?: string;
25-
wholePictureLogoSwitch?: boolean;
2625
};
2726

2827
/**
@@ -57,7 +56,6 @@ export const Masthead = ({
5756
hasPageSkin = false,
5857
hasPageSkinContentSelfConstrain = false,
5958
pageId,
60-
wholePictureLogoSwitch = false,
6159
}: Props) => (
6260
<header data-component="header">
6361
<Section
@@ -114,7 +112,6 @@ export const Masthead = ({
114112
showSlimNav={showSlimNav}
115113
hasPageSkin={hasPageSkin}
116114
pageId={pageId}
117-
wholePictureLogoSwitch={wholePictureLogoSwitch}
118115
/>
119116
</Island>
120117
</header>
Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,10 @@
11
import { css } from '@emotion/react';
22
import { visuallyHidden } from '@guardian/source/foundations';
3-
import { Hide, SvgGuardianLogo } from '@guardian/source/react-components';
3+
import { SvgGuardianLogo } from '@guardian/source/react-components';
44
import { nestedOphanComponents } from '../../../lib/ophan-helpers';
55
import { palette } from '../../../palette';
6-
import TheWholePictureGuardianLogoSmall from '../../../static/icons/the-guardian-whole-picture-logo-small.svg';
7-
import TheWholePictureGuardianLogo from '../../../static/icons/the-guardian-whole-picture-logo.svg';
86

9-
type Props = {
10-
/**
11-
* We are running a campaign in the US called "The Whole Picture"
12-
* We will use a different logo for the US edition for the duration of this campaign.
13-
*/
14-
showWholePictureLogo: boolean;
15-
};
16-
17-
export const Logo = ({ showWholePictureLogo }: Props) => (
7+
export const Logo = () => (
188
<a href="/" data-link-name={nestedOphanComponents('header', 'logo')}>
199
<span
2010
css={css`
@@ -23,18 +13,6 @@ export const Logo = ({ showWholePictureLogo }: Props) => (
2313
>
2414
The Guardian - Back to home
2515
</span>
26-
27-
{showWholePictureLogo ? (
28-
<>
29-
<Hide from="tablet">
30-
<TheWholePictureGuardianLogoSmall />
31-
</Hide>
32-
<Hide until="tablet">
33-
<TheWholePictureGuardianLogo />
34-
</Hide>
35-
</>
36-
) : (
37-
<SvgGuardianLogo textColor={palette('--masthead-nav-link-text')} />
38-
)}
16+
<SvgGuardianLogo textColor={palette('--masthead-nav-link-text')} />
3917
</a>
4018
);

dotcom-rendering/src/components/Titlepiece.importable.tsx

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ interface Props {
3333
showSlimNav?: boolean;
3434
hasPageSkin?: boolean;
3535
pageId?: string;
36-
wholePictureLogoSwitch?: boolean;
3736
}
3837

3938
const gridContent = css`
@@ -101,22 +100,6 @@ const logoStylesFromLeftCol = css`
101100
}
102101
`;
103102

104-
const theWholePictureStyles = css`
105-
margin-bottom: 2px;
106-
${from.tablet} {
107-
margin-top: 10px;
108-
margin-bottom: 6px;
109-
}
110-
111-
svg {
112-
height: auto;
113-
width: 173px;
114-
${from.tablet} {
115-
width: 246px;
116-
}
117-
}
118-
`;
119-
120103
const slimNavLogoOverrides = css`
121104
position: relative;
122105
margin-top: ${space[2]}px;
@@ -337,13 +320,9 @@ export const Titlepiece = ({
337320
showSlimNav,
338321
hasPageSkin,
339322
pageId = '',
340-
wholePictureLogoSwitch,
341323
}: Props) => {
342324
const { showBanner } = useEditionSwitcherBanner(pageId, editionId);
343325

344-
const showWholePictureLogo =
345-
!!wholePictureLogoSwitch && !showSlimNav && editionId === 'US';
346-
347326
return (
348327
<Grid
349328
type="nav"
@@ -527,10 +506,9 @@ export const Titlepiece = ({
527506
logoStyles,
528507
!hasPageSkin && logoStylesFromLeftCol,
529508
showSlimNav && slimNavLogoOverrides,
530-
showWholePictureLogo && theWholePictureStyles,
531509
]}
532510
>
533-
<Logo showWholePictureLogo={showWholePictureLogo} />
511+
<Logo />
534512
</div>
535513

536514
{/** Expanded menu checkbox */}

dotcom-rendering/src/layouts/AllEditorialNewslettersPageLayout.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export const AllEditorialNewslettersPageLayout = ({
4444
showSlimNav={false}
4545
hasPageSkin={false}
4646
hasPageSkinContentSelfConstrain={false}
47-
wholePictureLogoSwitch={config.switches.wholePictureLogo}
4847
/>
4948
</div>
5049

dotcom-rendering/src/layouts/AudioLayout.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,6 @@ export const AudioLayout = (props: WebProps) => {
184184
showSlimNav={false}
185185
hasPageSkinContentSelfConstrain={true}
186186
pageId={article.pageId}
187-
wholePictureLogoSwitch={
188-
article.config.switches.wholePictureLogo
189-
}
190187
/>
191188
</div>
192189

dotcom-rendering/src/layouts/CommentLayout.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,6 @@ export const CommentLayout = (props: WebProps | AppsProps) => {
335335
hasPageSkin={false}
336336
hasPageSkinContentSelfConstrain={false}
337337
pageId={article.pageId}
338-
wholePictureLogoSwitch={
339-
article.config.switches.wholePictureLogo
340-
}
341338
/>
342339
</div>
343340
)}

dotcom-rendering/src/layouts/CrosswordLayout.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,6 @@ export const CrosswordLayout = (props: Props) => {
157157
hasPageSkin={false}
158158
hasPageSkinContentSelfConstrain={false}
159159
pageId={article.pageId}
160-
wholePictureLogoSwitch={
161-
article.config.switches.wholePictureLogo
162-
}
163160
/>
164161
</div>
165162

dotcom-rendering/src/layouts/FrontLayout.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,9 +234,6 @@ export const FrontLayout = ({ front, NAV }: Props) => {
234234
hasPageSkin={hasPageSkin}
235235
hasPageSkinContentSelfConstrain={true}
236236
pageId={pageId}
237-
wholePictureLogoSwitch={
238-
front.config.switches.wholePictureLogo
239-
}
240237
/>
241238

242239
{isPaidContent && (

dotcom-rendering/src/layouts/FullPageInteractiveLayout.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,9 +181,6 @@ const NavHeader = ({ article, NAV, renderAds }: HeaderProps) => {
181181
hasPageSkin={false}
182182
hasPageSkinContentSelfConstrain={false}
183183
pageId={article.pageId}
184-
wholePictureLogoSwitch={
185-
article.config.switches.wholePictureLogo
186-
}
187184
/>
188185
</section>
189186
);

0 commit comments

Comments
 (0)