Commit 85f32b1
Two step dismissible banner (#14312)
* add buttons
* toggle icon, toggle layout css, toggle close button
* adds css ready for grid layout changes
* pass abtest through to component, use to alter style
* pass through abtest and use to show hide benefits
* move button, try layout change for collapsed
* fix isInTest prop type
* fix style lint issues
* prettier fix
* handle hide pill on choice card
* use mobile copy for collapsed banner
* tidy logic
* adds todo item reminder
* show only selected choice in collapsed state
* reduce complexity around passed booleans
* reduce complexity around passed booleans
* reduce complexity around passed booleans
* ensure using specific test, variant combo when applying dismissible changes
* wip: working on layout around close button
* close button layout fixes, change to LinkButton, surprising overrides required
* revert ThreeTierChoiceCards and hide if inABTest and isCollapsed
* revert body copy check and hide body copy on collapse
* tweaks to get phablet layout fixed
* style lint does not like tabs in grid-template-areas
* add margin-bottom to headline if collapsed
* ensure consistent tabs in grid-template-areas - useful to see layout more easily
* fix phablet to desktop layout
* ensure cta is level with headline, vert line, logo when collapsed
* ensure close button on left till phablet
* remove unnecessary style
* Update variant name
* add story
* tidy
* unnecessary fragment
* rename isInABTest
* Add tracking
* position tweaks
* margin at desktop only
* improve tablet and tidy
* remove unused code
* ===
* includes variant name
* Fix heading font size
* Use cta copy from tool if collapsed
---------
Co-authored-by: sookburt <“sue.burt@guardian.co.uk”>
Co-authored-by: Tom Forbes <tom.forbes@theguardian.com>1 parent 666945d commit 85f32b1
File tree
7 files changed
+332
-61
lines changed- dotcom-rendering/src/components/marketing
- banners
- common
- designableBanner
- components
- stories
7 files changed
+332
-61
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
298 | 300 | | |
299 | 301 | | |
300 | 302 | | |
| 303 | + | |
| 304 | + | |
301 | 305 | | |
302 | 306 | | |
303 | 307 | | |
| |||
316 | 320 | | |
317 | 321 | | |
318 | 322 | | |
| 323 | + | |
| 324 | + | |
319 | 325 | | |
320 | 326 | | |
321 | 327 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
| |||
0 commit comments