use human-readable function name for lambda

Author: cemms1

ab-testing/cdk/lib/__snapshots__/notificationLambda.test.ts.snap

@@ -317,6 +317,7 @@ exports[`The AB testing notification lambda stack > matches the CODE snapshot 1`
             "APP": "ab-testing-notification-lambda"
           }
         },
+        "FunctionName": "ab-testing-notification-lambda-CODE",
         "Handler": "index.handler",
         "LoggingConfig": {
           "LogFormat": "JSON"
@@ -382,29 +383,8 @@ exports[`The AB testing notification lambda stack > matches the CODE snapshot 1`
             ]
           }
         ],
-        "AlarmDescription": {
-          "Fn::Join": [
-            "",
-            [
-              {
-                "Ref": "AbTestingNotificationLambda36F153E8"
-              },
-              " exceeded 0% error rate"
-            ]
-          ]
-        },
-        "AlarmName": {
-          "Fn::Join": [
-            "",
-            [
-              "High error percentage from ",
-              {
-                "Ref": "AbTestingNotificationLambda36F153E8"
-              },
-              " lambda in CODE"
-            ]
-          ]
-        },
+        "AlarmDescription": "Something went wrong notifying test owners of upcoming AB test expiries in the CODE AB Testing Notification Lambda. Please check the logs",
+        "AlarmName": "AB Testing Notification Lambda Failures",
         "ComparisonOperator": "GreaterThanThreshold",
         "EvaluationPeriods": 1,
         "Metrics": [
@@ -465,6 +445,26 @@ exports[`The AB testing notification lambda stack > matches the CODE snapshot 1`
             "ReturnData": false
           }
         ],
+        "OKActions": [
+          {
+            "Fn::Join": [
+              "",
+              [
+                "arn:aws:sns:eu-west-1:",
+                {
+                  "Ref": "AWS::AccountId"
+                },
+                ":",
+                {
+                  "Fn::GetAtt": [
+                    "AbTestingNotificationSnsTopicB3559144",
+                    "TopicName"
+                  ]
+                }
+              ]
+            ]
+          }
+        ],
         "Tags": [
           {
             "Key": "gu:cdk:version",
@@ -827,6 +827,7 @@ exports[`The AB testing notification lambda stack > matches the PROD snapshot 1`
             "APP": "ab-testing-notification-lambda"
           }
         },
+        "FunctionName": "ab-testing-notification-lambda-PROD",
         "Handler": "index.handler",
         "LoggingConfig": {
           "LogFormat": "JSON"
@@ -952,29 +953,8 @@ exports[`The AB testing notification lambda stack > matches the PROD snapshot 1`
             ]
           }
         ],
-        "AlarmDescription": {
-          "Fn::Join": [
-            "",
-            [
-              {
-                "Ref": "AbTestingNotificationLambda36F153E8"
-              },
-              " exceeded 0% error rate"
-            ]
-          ]
-        },
-        "AlarmName": {
-          "Fn::Join": [
-            "",
-            [
-              "High error percentage from ",
-              {
-                "Ref": "AbTestingNotificationLambda36F153E8"
-              },
-              " lambda in PROD"
-            ]
-          ]
-        },
+        "AlarmDescription": "Something went wrong notifying test owners of upcoming AB test expiries in the PROD AB Testing Notification Lambda. Please check the logs",
+        "AlarmName": "AB Testing Notification Lambda Failures",
         "ComparisonOperator": "GreaterThanThreshold",
         "EvaluationPeriods": 1,
         "Metrics": [
@@ -1035,6 +1015,26 @@ exports[`The AB testing notification lambda stack > matches the PROD snapshot 1`
             "ReturnData": false
           }
         ],
+        "OKActions": [
+          {
+            "Fn::Join": [
+              "",
+              [
+                "arn:aws:sns:eu-west-1:",
+                {
+                  "Ref": "AWS::AccountId"
+                },
+                ":",
+                {
+                  "Fn::GetAtt": [
+                    "AbTestingNotificationSnsTopicB3559144",
+                    "TopicName"
+                  ]
+                }
+              ]
+            ]
+          }
+        ],
         "Tags": [
           {
             "Key": "gu:cdk:version",

ab-testing/cdk/lib/notificationLambda.ts

@@ -10,7 +10,7 @@ import { Effect, PolicyStatement } from "aws-cdk-lib/aws-iam";
 import { Runtime } from "aws-cdk-lib/aws-lambda";
 import { Subscription, SubscriptionProtocol, Topic } from "aws-cdk-lib/aws-sns";
 
-const lambdaFunctionName = "ab-testing-notification-lambda";
+const appName = "ab-testing-notification-lambda";
 
 const getEmailDomain = (stage: GuStackProps["stage"]) => {
 	switch (stage) {
@@ -33,7 +33,7 @@ export class AbTestingNotificationLambda extends GuStack {
 		};
 
 		const emailIdentity = new GuEmailIdentity(this, "EmailIdentity", {
-			app: lambdaFunctionName,
+			app: appName,
 			domainName: getEmailDomain(props.stage),
 		});
 
@@ -53,13 +53,17 @@ export class AbTestingNotificationLambda extends GuStack {
 			this,
 			"AbTestingNotificationLambda",
 			{
-				app: lambdaFunctionName,
+				functionName: `${appName}-${props.stage}`,
+				app: appName,
 				fileName: "lambda.zip",
 				handler: "index.handler",
 				rules: this.stage === "PROD" ? [runDailyRule] : [],
 				monitoringConfiguration: {
 					snsTopicName: snsTopic.topicName,
 					toleratedErrorPercentage: 0,
+					alarmName: "AB Testing Notification Lambda Failures",
+					alarmDescription: `Something went wrong notifying test owners of upcoming AB test expiries in the ${props.stage} AB Testing Notification Lambda. Please check the logs`,
+					okAction: true,
 				},
 				runtime: Runtime.NODEJS_22_X,
 				environment: {