Skip to content

Commit 8d7d6e2

Browse files
committed
update spacing above sponsored content component to be 8px in all scenarios
1 parent 2211f62 commit 8d7d6e2

File tree

3 files changed

+16
-22
lines changed

3 files changed

+16
-22
lines changed

dotcom-rendering/src/components/FeatureCard.tsx

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const hoverStyles = css`
9090

9191
/** When we hover on sublinks, we want to prevent the general hover styles applying */
9292
const sublinkHoverStyles = css`
93-
:has(ul.sublinks:hover) {
93+
:has(ul.sublinks:hover, .branding-logo:hover) {
9494
.card-headline .show-underline {
9595
text-decoration: none;
9696
}
@@ -235,10 +235,6 @@ const waveformStyles = css`
235235
opacity: 0.3;
236236
`;
237237

238-
const wrapperStyles = css`
239-
padding-top: ${space[3]}px;
240-
`;
241-
242238
const getMedia = ({
243239
imageUrl,
244240
imageAltText,
@@ -738,20 +734,18 @@ export const FeatureCard = ({
738734
/>
739735
)}
740736
{isLabs && branding && showLabsRedesign && (
741-
<div css={wrapperStyles}>
742-
<SponsoredContentLabel
743-
branding={branding}
744-
containerPalette={containerPalette}
745-
orientation="horizontal"
746-
alignment="end"
747-
ophanComponentLink={
748-
labsDataAttributes?.ophanComponentLink
749-
}
750-
ophanComponentName={
751-
labsDataAttributes?.ophanComponentName
752-
}
753-
/>
754-
</div>
737+
<SponsoredContentLabel
738+
branding={branding}
739+
containerPalette={containerPalette}
740+
orientation="horizontal"
741+
alignment="end"
742+
ophanComponentLink={
743+
labsDataAttributes?.ophanComponentLink
744+
}
745+
ophanComponentName={
746+
labsDataAttributes?.ophanComponentName
747+
}
748+
/>
755749
)}
756750
</div>
757751
</ContainerOverrides>

dotcom-rendering/src/components/FrontSection.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,13 +499,12 @@ const sponsoredContentLabelWrapper = css`
499499
grid-row: bottom-content;
500500
grid-column: content;
501501
502-
margin: ${space[1]}px 0 0;
503502
${from.tablet} {
504503
/*
505504
* side margins of 10px due to the -10px margins on the
506505
* grid area for content, to align with the card edges
507506
*/
508-
margin: ${space[1]}px 10px 0;
507+
margin: 0 10px;
509508
}
510509
`;
511510

dotcom-rendering/src/components/SponsoredContentLabel.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ const labelStyles = css`
3434
`;
3535

3636
const wrapperStyles = css`
37-
padding-top: ${space[1]}px;
37+
padding-top: ${space[2]}px;
3838
display: flex;
3939
justify-content: end;
40+
gap: ${space[1]}px;
4041
`;
4142

4243
const horizontalStyles = css`

0 commit comments

Comments
 (0)