Merge pull request #14222 from guardian/ih/ab-test-cleanup

Remove expired commercial A/B tests and related code

Author: i-hardy

dotcom-rendering/src/components/AdBlockAsk.importable.tsx

@@ -16,8 +16,6 @@ import { ArticleDisplay } from '../lib/articleFormat';
 import { getZIndex } from '../lib/getZIndex';
 import { LABS_HEADER_HEIGHT } from '../lib/labs-constants';
 import { palette as schemedPalette } from '../palette';
-import { AdBlockAsk } from './AdBlockAsk.importable';
-import { Island } from './Island';
 
 // There are multiple of these ad slots on the page
 type IndexedSlot =
@@ -433,7 +431,6 @@ export const AdSlot = ({
 	isPaidContent = false,
 	index,
 	hasPageskin = false,
-	shouldHideReaderRevenue = false,
 	isIn250ReservationVariant,
 }: Props) => {
 	switch (position) {
@@ -488,19 +485,6 @@ export const AdSlot = ({
 					const slotId = 'dfp-ad--right';
 					return (
 						<>
-							<Island
-								priority="feature"
-								defer={{ until: 'visible' }}
-							>
-								<AdBlockAsk
-									size="mpu"
-									slotId={slotId}
-									isPaidContent={isPaidContent}
-									shouldHideReaderRevenue={
-										shouldHideReaderRevenue
-									}
-								/>
-							</Island>
 							<AdSlotWrapper
 								css={[
 									css`

dotcom-rendering/src/components/AdBlockAskLeaderboard.stories.tsx

@@ -3,10 +3,8 @@ import { adSizes, constants } from '@guardian/commercial';
 import { space } from '@guardian/source/foundations';
 import { palette } from '../palette';
 import type { ServerSideTests } from '../types/config';
-import { AdBlockAsk } from './AdBlockAsk.importable';
 import { AdSlot } from './AdSlot.web';
 import { Hide } from './Hide';
-import { Island } from './Island';
 
 const headerWrapper = css`
 	position: static;
@@ -56,15 +54,7 @@ const headerMinSizeStyles = css`
 	min-width: ${adSizes.leaderboard.width}px;
 `;
 
-export const HeaderAdSlot = ({
-	shouldHideReaderRevenue,
-	isPaidContent,
-	abTests,
-}: {
-	shouldHideReaderRevenue: boolean;
-	isPaidContent: boolean;
-	abTests: ServerSideTests;
-}) => {
+export const HeaderAdSlot = ({ abTests }: { abTests: ServerSideTests }) => {
 	const isIn250ReservationVariant =
 		abTests.topAboveNav250ReservationVariant === 'variant';
 	return (
@@ -94,16 +84,6 @@ export const HeaderAdSlot = ({
 					<div
 						css={!isIn250ReservationVariant && headerMinSizeStyles}
 					>
-						<Island priority="feature" defer={{ until: 'visible' }}>
-							<AdBlockAsk
-								size="leaderboard"
-								slotId="dfp-ad--top-above-nav"
-								shouldHideReaderRevenue={
-									shouldHideReaderRevenue
-								}
-								isPaidContent={isPaidContent}
-							/>
-						</Island>
 						<AdSlot
 							position="top-above-nav"
 							isIn250ReservationVariant={

dotcom-rendering/src/components/AdBlockAskMPU.stories.tsx

@@ -10,8 +10,6 @@ import {
 } from '@guardian/core-web-vitals';
 import { getCookie, isString, isUndefined } from '@guardian/libs';
 import { useCallback, useEffect, useState } from 'react';
-import { adBlockAsk } from '../experiments/tests/ad-block-ask';
-import { integrateIma } from '../experiments/tests/integrate-ima';
 import { useAB } from '../lib/useAB';
 import { useAdBlockInUse } from '../lib/useAdBlockInUse';
 import { useDetectAdBlock } from '../lib/useDetectAdBlock';
@@ -31,8 +29,6 @@ const willRecordCoreWebVitals = Math.random() < sampling;
 // For these tests switch off sampling and collect metrics for 100% of views
 const clientSideTestsToForceMetrics: ABTest[] = [
 	/* keep array multi-line */
-	integrateIma,
-	adBlockAsk,
 ];
 
 const useBrowserId = () => {

dotcom-rendering/src/components/AdSlot.web.tsx

@@ -1,10 +1,6 @@
 import type { ABTest } from '@guardian/ab-core';
 import { abTestTest } from './tests/ab-test-test';
-import { adBlockAsk } from './tests/ad-block-ask';
 import { auxiaSignInGate } from './tests/auxia-sign-in-gate';
-import { consentlessAds } from './tests/consentless-ads';
-import { integrateIma } from './tests/integrate-ima';
-import { optimiseSpacefinderInline } from './tests/optimise-spacefinder-inline';
 import { signInGateMainControl } from './tests/sign-in-gate-main-control';
 import { signInGateMainVariant } from './tests/sign-in-gate-main-variant';
 import { userBenefitsApi } from './tests/user-benefits-api';
@@ -15,10 +11,6 @@ export const tests: ABTest[] = [
 	abTestTest,
 	signInGateMainVariant,
 	signInGateMainControl,
-	consentlessAds,
-	integrateIma,
-	adBlockAsk,
-	optimiseSpacefinderInline,
 	userBenefitsApi,
 	auxiaSignInGate,
 ];