Skip to content

Commit 94a378c

Browse files
committed
Wip including using content provided by frontend
1 parent da60169 commit 94a378c

File tree

4 files changed

+82
-804
lines changed

4 files changed

+82
-804
lines changed

dotcom-rendering/src/components/StorylineSection.tsx

Lines changed: 28 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
from,
55
space,
66
textSans14,
7-
textSans17,
87
until,
98
} from '@guardian/source/foundations';
109
import { type EditionId, isNetworkFront } from '../lib/edition';
@@ -18,10 +17,8 @@ import type {
1817
import type { TagPagePagination } from '../types/tagPage';
1918
import { ContainerOverrides } from './ContainerOverrides';
2019
import { ContainerTitle } from './ContainerTitle';
21-
import { FrontPagination } from './FrontPagination';
2220
import { FrontSectionTitle } from './FrontSectionTitle';
2321
import { ShowHideButton } from './ShowHideButton';
24-
import { Treats } from './Treats';
2522
import { Footer } from './ExpandableAtom/Footer';
2623
import { submitComponentEvent } from '../client/ophan/ophan';
2724

@@ -388,13 +385,13 @@ const sectionContentBorderFromLeftCol = css`
388385
}
389386
`;
390387

391-
const sectionBottomContent = css`
392-
grid-row: bottom-content;
393-
grid-column: content;
394-
.hidden > & {
395-
display: none;
396-
}
397-
`;
388+
// const sectionBottomContent = css`
389+
// grid-row: bottom-content;
390+
// grid-column: content;
391+
// .hidden > & {
392+
// display: none;
393+
// }
394+
// `;
398395

399396
const sectionTreats = css`
400397
/* Mobile: treats appear at the bottom */
@@ -440,25 +437,25 @@ const topBorder = css`
440437
border-top-style: solid;
441438
`;
442439

443-
const bottomPadding = css`
444-
padding-bottom: ${space[4]}px;
445-
`;
440+
// const bottomPadding = css`
441+
// padding-bottom: ${space[4]}px;
442+
// `;
446443

447-
const bottomPaddingBetaContainer = (
448-
useLargeSpacingMobile: boolean,
449-
useLargeSpacingDesktop: boolean,
450-
) => css`
451-
${until.tablet} {
452-
padding-bottom: ${useLargeSpacingMobile
453-
? `${space[8]}px`
454-
: `${space[4]}px`};
455-
}
456-
${from.tablet} {
457-
padding-bottom: ${useLargeSpacingDesktop
458-
? `${space[8]}px`
459-
: `${space[4]}px`};
460-
}
461-
`;
444+
// const bottomPaddingBetaContainer = (
445+
// useLargeSpacingMobile: boolean,
446+
// useLargeSpacingDesktop: boolean,
447+
// ) => css`
448+
// ${until.tablet} {
449+
// padding-bottom: ${useLargeSpacingMobile
450+
// ? `${space[8]}px`
451+
// : `${space[4]}px`};
452+
// }
453+
// ${from.tablet} {
454+
// padding-bottom: ${useLargeSpacingDesktop
455+
// ? `${space[8]}px`
456+
// : `${space[4]}px`};
457+
// }
458+
// `;
462459

463460
const primaryLevelTopBorder = (
464461
title?: string,
@@ -608,9 +605,9 @@ export const StorylineSection = ({
608605
const isBetaContainer = !!containerLevel;
609606

610607
// These are for beta containers only
611-
const useLargeSpacingMobile = !!isNextCollectionPrimary || isAboveMobileAd;
612-
const useLargeSpacingDesktop =
613-
!!isNextCollectionPrimary || isAboveDesktopAd;
608+
// const useLargeSpacingMobile = !!isNextCollectionPrimary || isAboveMobileAd;
609+
// const useLargeSpacingDesktop =
610+
// !!isNextCollectionPrimary || isAboveDesktopAd;
614611

615612
const showSectionColours = isNetworkFront(pageId ?? '');
616613

0 commit comments

Comments
 (0)