Skip to content

Commit 961422d

Browse files
authored
2-step banner: hide ticker + image when collapsed (#14432)
* 2-step banner: hide ticker + image when collapsed * also hide article count
1 parent 1140ebb commit 961422d

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
345345
}
346346
/>
347347
</div>
348-
{showAboveArticleCount && (
348+
{showAboveArticleCount && !isCollapsed && (
349349
<div css={styles.articleCountContainer}>
350350
<DesignableBannerArticleCount
351351
numArticles={articleCounts.forTargetedWeeks}
@@ -355,6 +355,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
355355
</div>
356356
)}
357357
{tickerSettings?.tickerData &&
358+
!isCollapsed &&
358359
templateSettings.tickerStylingSettings && (
359360
<div css={templateSpacing.bannerTicker}>
360361
<Ticker
@@ -389,7 +390,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
389390
)}
390391
</div>
391392

392-
{templateSettings.imageSettings && (
393+
{templateSettings.imageSettings && !isCollapsed && (
393394
<div css={styles.bannerVisualContainer}>
394395
<DesignableBannerVisual
395396
settings={templateSettings.imageSettings}

dotcom-rendering/src/components/marketing/banners/designableBanner/stories/DesignableBanner.stories.tsx

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -357,5 +357,24 @@ export const CollapsableWithThreeTierChoiceCards: Story = {
357357
},
358358
choiceCardAmounts: regularChoiceCardAmounts,
359359
choiceCardsSettings,
360+
tickerSettings,
361+
separateArticleCountSettings: {
362+
type: 'above',
363+
},
364+
},
365+
};
366+
367+
export const CollapsableWithMainImage: Story = {
368+
name: 'Collapsable with main image',
369+
args: {
370+
...meta.args,
371+
design: {
372+
...design,
373+
visual: regularImage,
374+
},
375+
tracking: {
376+
...tracking,
377+
abTestVariant: 'COLLAPSABLE_V1',
378+
},
360379
},
361380
};

0 commit comments

Comments
 (0)