Skip to content

Commit 96c68e9

Browse files
committed
fix the background colours for gallery
1 parent bdde5fb commit 96c68e9

File tree

4 files changed

+16
-5
lines changed

4 files changed

+16
-5
lines changed

dotcom-rendering/src/components/GalleryImage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ type Props = {
1818
const styles = css`
1919
${grid.paddedContainer}
2020
grid-auto-flow: row dense;
21+
background-color: ${palette('--article-inner-background')};
2122
2223
${until.tablet} {
2324
border-top: 1px solid ${palette('--article-border')};

dotcom-rendering/src/components/SubMeta.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ const syndicationButtonOverrides = css`
127127
}
128128
`;
129129

130+
const galleryStyles = css`
131+
${grid.paddedContainer};
132+
background-color: ${palette('--article-inner-background')};
133+
`;
134+
130135
export const SubMeta = ({
131136
format,
132137
subMetaKeywordLinks,
@@ -160,7 +165,7 @@ export const SubMeta = ({
160165
? setMetaWidth
161166
: undefined,
162167
format.design === ArticleDesign.Gallery
163-
? grid.container
168+
? galleryStyles
164169
: undefined,
165170
]}
166171
>

dotcom-rendering/src/layouts/GalleryLayout.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ const border = css({
3636
color: '#ccc',
3737
});
3838

39+
const headerStyles = css`
40+
${grid.container}
41+
background-color: ${palette('--article-inner-background')};
42+
`;
43+
3944
export const GalleryLayout = (props: WebProps | AppProps) => {
4045
const gallery = props.gallery;
4146
const frontendData = gallery.frontendData;
@@ -68,11 +73,11 @@ export const GalleryLayout = (props: WebProps | AppProps) => {
6873
)}
6974
<main
7075
css={{
71-
backgroundColor: palette('--article-inner-background'),
76+
backgroundColor: palette('--article-background'),
7277
}}
7378
>
7479
<div css={border}>Labs header</div>
75-
<header css={[grid.container]}>
80+
<header css={headerStyles}>
7681
<MainMediaGallery
7782
mainMedia={gallery.mainMedia}
7883
format={format}

dotcom-rendering/src/paletteDeclarations.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2989,7 +2989,7 @@ const articleBackgroundLight: PaletteFunction = ({
29892989
case ArticleDesign.FullPageInteractive:
29902990
return 'transparent';
29912991
case ArticleDesign.Gallery:
2992-
return transparentColour(sourcePalette.neutral[0], 0.25);
2992+
return '#0d0d0d';
29932993
default:
29942994
switch (theme) {
29952995
case ArticleSpecial.SpecialReport:
@@ -3034,7 +3034,7 @@ const articleBackgroundDark: PaletteFunction = ({ design, theme }) => {
30343034
return sourcePalette.neutral[10];
30353035
}
30363036
case ArticleDesign.Gallery:
3037-
return transparentColour(sourcePalette.neutral[0], 0.25);
3037+
return '#131313';
30383038
default:
30393039
return sourcePalette.neutral[10];
30403040
}

0 commit comments

Comments
 (0)