Move and rename Front types (#13622)

The purpose of this change is to refactor and simplify the codebase,
making it clearer which types and files relate to the data that comes
from frontend. The new `frontend` directory has been used to contain
frontend types and their corresponding schemas. Currently these are
distributed across the codebase and it can be difficult to follow their
usage. The files in this change to be moved into this directory are
`feFront.ts`, a new file to hold the `FEFront` type, and `feFront.json`,
the existing front JSON schema file. The other frontend types and
schemas will follow in later changes, as moving them all together would
constitute a very large diff.

This change also renames `FEFrontType` to `FEFront` and `DCRFrontType`
to `Front`. Removal of the `DCR` prefix has occurred for two reasons.
Firstly, the project is now called DCAR. Secondly, we're in DCAR
(previously DCR), so we can assume all types without a prefix belong to
this project. By contrast, any type that's derived from frontend remains
prefixed with `FE` to differentiate it. The `Type` suffix has been
removed because it's not necessary to suffix a type with the word
`Type`, and this convention was applied inconsistently, so removing it
reduces noise in the codebase.

The removal of the `Type` suffix has also been applied to any types that
now live in the new `feFront.ts` file. However, the `DCR` prefix and
`Type` suffix remain on any types that still live in the `front.ts`
file. These types are used more widely, so a rename would have resulted
in changes to many more files. They will instead be renamed in a
subsequent change, to avoid making this change too large.

Author: JamieB-gu

dotcom-rendering/fixtures/manual/show-more-trails.ts

@@ -4,7 +4,7 @@
  * Exporting this 'as' FEFrontCard because we know it should be of the right shape.
  */
 
-import type { FEFrontCard } from '../../src/types/front';
+import type { FEFrontCard } from '../../src/frontend/feFront';
 
 export const trails: [
 	FEFrontCard,

dotcom-rendering/scripts/jsonSchema/schema.mjs

@@ -11,6 +11,7 @@ const program = TJS.getProgramFromFiles(
 	[
 		path.resolve(`${root}/index.d.ts`),
 		path.resolve(`${root}/src/types/frontend.ts`),
+		path.resolve(`${root}/src/frontend/feFront.ts`),
 		path.resolve(`${root}/src/frontend/feTagPage.ts`),
 		path.resolve(`${root}/src/types/newslettersPage.ts`),
 		path.resolve(`${root}/src/types/editionsCrossword.ts`),
@@ -38,8 +39,8 @@ const schemas = [
 		file: `${root}/src/model/article-schema.json`,
 	},
 	{
-		typeName: 'FEFrontType',
-		file: `${root}/src/model/front-schema.json`,
+		typeName: 'FEFront',
+		file: `${root}/src/frontend/schemas/feFront.json`,
 	},
 	{
 		typeName: 'FETagPage',

dotcom-rendering/src/components/FrontPage.tsx

@@ -6,7 +6,7 @@ import { ArticleDesign, ArticleDisplay, Pillar } from '../lib/articleFormat';
 import { rootStyles } from '../lib/rootStyles';
 import { filterABTestSwitches } from '../model/enhance-switches';
 import type { NavType } from '../model/extract-nav';
-import type { DCRFrontType } from '../types/front';
+import type { Front } from '../types/front';
 import { AlreadyVisited } from './AlreadyVisited.importable';
 import { BrazeMessaging } from './BrazeMessaging.importable';
 import { useConfig } from './ConfigContext';
@@ -21,7 +21,7 @@ import { ShowHideContainers } from './ShowHideContainers.importable';
 import { SkipTo } from './SkipTo';
 
 type Props = {
-	front: DCRFrontType;
+	front: Front;
 	NAV: NavType;
 };
 
@@ -30,7 +30,7 @@ type Props = {
  * FrontPage is a high level wrapper for front pages on Dotcom. Sets strict mode and some globals
  *
  * @param {Props} props
- * @param {DCRFrontType} props.front - The article JSON data
+ * @param {Front} props.front - The article JSON data
  * @param {NAVType} props.NAV - The article JSON data
  * */
 export const FrontPage = ({ front, NAV }: Props) => {

dotcom-rendering/src/components/ShowMore.importable.tsx

@@ -14,11 +14,12 @@ import {
 	SvgPlus,
 } from '@guardian/source/react-components';
 import { useEffect, useState } from 'react';
+import type { FEFrontCard } from '../frontend/feFront';
 import { shouldPadWrappableRows } from '../lib/dynamicSlices';
 import type { EditionId } from '../lib/edition';
 import { useApi } from '../lib/useApi';
 import { enhanceCards } from '../model/enhanceCards';
-import type { DCRContainerPalette, FEFrontCard } from '../types/front';
+import type { DCRContainerPalette } from '../types/front';
 import { LI } from './Card/components/LI';
 import { UL } from './Card/components/UL';
 import { FrontCard } from './FrontCard';

dotcom-rendering/src/feFootballDataPage.ts

@@ -1,6 +1,6 @@
+import type { FEFrontConfig } from './frontend/feFront';
 import type { EditionId } from './lib/edition';
 import type { FooterType } from './types/footer';
-import type { FEFrontConfigType } from './types/front';
 import type { FENavType } from './types/frontend';
 
 type FECompetitionSummary = {
@@ -100,7 +100,7 @@ export type FEMatchByDateAndCompetition = {
 };
 
 export type FEFootballPageConfig = Omit<
-	FEFrontConfigType,
+	FEFrontConfig,
 	'keywordIds' | 'keywords' | 'isFront'
 > & {
 	isFront: boolean;