Skip to content

Commit ba723b1

Browse files
committed
Remove intial fix in favour of enhancers change
1 parent 1dd7569 commit ba723b1

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

dotcom-rendering/src/components/ProductElement.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ const Content = ({
124124
key={index}
125125
index={index}
126126
format={format}
127-
isProduct={true}
128127
isMainMedia={false}
129128
/>
130129
))}

dotcom-rendering/src/lib/renderElement.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ type Props = {
9393
editionId: EditionId;
9494
forceDropCap?: 'on' | 'off';
9595
isTimeline?: boolean;
96-
isProduct?: boolean;
9796
totalElements?: number;
9897
isListElement?: boolean;
9998
isSectionedMiniProfilesArticle?: boolean;
@@ -165,7 +164,6 @@ export const renderElement = ({
165164
editionId,
166165
forceDropCap,
167166
isTimeline = false,
168-
isProduct = false,
169167
totalElements = 0,
170168
isListElement = false,
171169
isSectionedMiniProfilesArticle = false,
@@ -555,7 +553,7 @@ export const renderElement = ({
555553
successDescription: element.newsletter.successDescription,
556554
theme: element.newsletter.theme,
557555
};
558-
if (isListElement || isTimeline || isProduct) return null;
556+
if (isListElement || isTimeline) return null;
559557
return <EmailSignUpWrapper {...emailSignUpProps} />;
560558
case 'model.dotcomrendering.pageElements.AdPlaceholderBlockElement':
561559
return renderAds && <AdPlaceholder />;
@@ -987,7 +985,6 @@ export const RenderArticleElement = ({
987985
editionId,
988986
forceDropCap,
989987
isTimeline,
990-
isProduct,
991988
totalElements,
992989
isListElement,
993990
isSectionedMiniProfilesArticle,
@@ -1016,7 +1013,6 @@ export const RenderArticleElement = ({
10161013
editionId,
10171014
forceDropCap,
10181015
isTimeline,
1019-
isProduct,
10201016
totalElements,
10211017
isListElement,
10221018
isSectionedMiniProfilesArticle,
@@ -1057,7 +1053,6 @@ type ElementLevelPropNames =
10571053
| 'hideCaption'
10581054
| 'format'
10591055
| 'isTimeline'
1060-
| 'isProduct'
10611056
| 'isListElement'
10621057
| 'isMainMedia';
10631058
type ArticleLevelProps = Omit<Props, ElementLevelPropNames>;

0 commit comments

Comments
 (0)