Skip to content

Commit c47cdcd

Browse files
author
sookburt
committed
flag more unused
1 parent cdce8eb commit c47cdcd

File tree

5 files changed

+35
-27
lines changed

5 files changed

+35
-27
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/components/choiceCards/ChoiceCardInteractive.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,16 @@ import type {
1212
ContributionFrequency,
1313
SelectedAmountsVariant,
1414
} from '@guardian/support-dotcom-components/dist/shared/types';
15-
import type { ChoiceCardSelection } from '../../../../lib/choiceCards';
16-
import { contributionType } from '../../../../lib/choiceCards';
15+
import type { ChoiceCardSelection_unused } from '../../../../lib/choiceCards';
16+
import { contributionType_unused } from '../../../../lib/choiceCards';
1717
import type { ReactComponent } from '../../../../lib/ReactComponent';
1818
import type { ChoiceCardSettings } from './ChoiceCards';
1919

2020
interface ChoiceCardInteractiveProps {
21-
selection?: ChoiceCardSelection;
22-
setSelectionsCallback: (choiceCardSelection: ChoiceCardSelection) => void;
21+
selection?: ChoiceCardSelection_unused;
22+
setSelectionsCallback: (
23+
choiceCardSelection: ChoiceCardSelection_unused,
24+
) => void;
2325
submitComponentEvent?: (event: ComponentEvent) => void;
2426
currencySymbol: string;
2527
amountsTest?: SelectedAmountsVariant;
@@ -168,7 +170,7 @@ export const ChoiceCardInteractive_unused: ReactComponent<
168170
key={amount}
169171
value={`${amount}`}
170172
label={`${currencySymbol}${amount} ${
171-
contributionType[selection.frequency].suffix
173+
contributionType_unused[selection.frequency].suffix
172174
}`}
173175
id={`${componentId}-${amount}`}
174176
checked={selection.amount === amount}
@@ -220,7 +222,7 @@ export const ChoiceCardInteractive_unused: ReactComponent<
220222
const generateChoiceCardFrequencyTab = (
221223
frequency: ContributionFrequency,
222224
) => {
223-
const label = contributionType[frequency].label;
225+
const label = contributionType_unused[frequency].label;
224226
return (
225227
<ChoiceCard
226228
key={label}

dotcom-rendering/src/components/marketing/banners/designableBanner/components/choiceCards/ChoiceCards.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import type { SelectedAmountsVariant } from '@guardian/support-dotcom-components
1111
import { useEffect } from 'react';
1212
import { useIsInView } from '../../../../../../lib/useIsInView';
1313
import type { ContentType } from '../../../../hooks/useChoiceCards';
14-
import type { ChoiceCardSelection } from '../../../../lib/choiceCards';
14+
import type { ChoiceCardSelection_unused } from '../../../../lib/choiceCards';
1515
import type { ReactComponent } from '../../../../lib/ReactComponent';
1616
import { PaymentCards_unused } from '../../../common/PaymentCards';
1717
import { ChoiceCardInteractive_unused } from './ChoiceCardInteractive';
@@ -26,9 +26,11 @@ export interface ChoiceCardSettings {
2626
buttonSelectBorderColour?: string;
2727
}
2828

29-
interface ChoiceCardProps {
30-
selection?: ChoiceCardSelection;
31-
setSelectionsCallback: (choiceCardSelection: ChoiceCardSelection) => void;
29+
interface ChoiceCardProps_unused {
30+
selection?: ChoiceCardSelection_unused;
31+
setSelectionsCallback: (
32+
choiceCardSelection: ChoiceCardSelection_unused,
33+
) => void;
3234
submitComponentEvent?: (event: ComponentEvent) => void;
3335
currencySymbol: string;
3436
componentId: string;
@@ -91,7 +93,7 @@ const styles = {
9193
`,
9294
};
9395

94-
export const ChoiceCards_unused: ReactComponent<ChoiceCardProps> = ({
96+
export const ChoiceCards_unused: ReactComponent<ChoiceCardProps_unused> = ({
9597
selection,
9698
setSelectionsCallback,
9799
submitComponentEvent,
@@ -103,7 +105,7 @@ export const ChoiceCards_unused: ReactComponent<ChoiceCardProps> = ({
103105
getCtaUrl,
104106
cssCtaOverides,
105107
onCtaClick,
106-
}: ChoiceCardProps) => {
108+
}: ChoiceCardProps_unused) => {
107109
const [hasBeenSeen, setNode] = useIsInView({
108110
debounce: true,
109111
threshold: 0,

dotcom-rendering/src/components/marketing/epics/ctas/ContributionsEpicChoiceCards.tsx

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import type {
1515
} from '@guardian/support-dotcom-components/dist/shared/types';
1616
import { useEffect } from 'react';
1717
import { useIsInView } from '../../../../lib/useIsInView';
18-
import { contributionType } from '../../lib/choiceCards';
19-
import type { ChoiceCardSelection } from '../../lib/choiceCards';
18+
import { contributionType_unused } from '../../lib/choiceCards';
19+
import type { ChoiceCardSelection_unused } from '../../lib/choiceCards';
2020
import type { ReactComponent } from '../../lib/ReactComponent';
2121

2222
// CSS Styling
@@ -47,23 +47,25 @@ const container = css`
4747

4848
// ContributionsEpicChoiceCards - exported component
4949
// -------------------------------------------
50-
interface EpicChoiceCardProps {
51-
selection?: ChoiceCardSelection;
52-
setSelectionsCallback: (choiceCardSelection: ChoiceCardSelection) => void;
50+
interface EpicChoiceCardProps_unused {
51+
selection?: ChoiceCardSelection_unused;
52+
setSelectionsCallback: (
53+
choiceCardSelection: ChoiceCardSelection_unused,
54+
) => void;
5355
submitComponentEvent?: (event: ComponentEvent) => void;
5456
currencySymbol: string;
5557
amountsTest: SelectedAmountsVariant;
5658
}
5759

5860
export const ContributionsEpicChoiceCards_unused: ReactComponent<
59-
EpicChoiceCardProps
61+
EpicChoiceCardProps_unused
6062
> = ({
6163
selection,
6264
setSelectionsCallback,
6365
submitComponentEvent,
6466
currencySymbol,
6567
amountsTest,
66-
}: EpicChoiceCardProps) => {
68+
}: EpicChoiceCardProps_unused) => {
6769
const [hasBeenSeen, setNode] = useIsInView({
6870
debounce: true,
6971
threshold: 0,
@@ -133,7 +135,7 @@ export const ContributionsEpicChoiceCards_unused: ReactComponent<
133135
<ChoiceCard
134136
value={`${amount}`}
135137
label={`${currencySymbol}${amount} ${
136-
contributionType[selection.frequency].suffix
138+
contributionType_unused[selection.frequency].suffix
137139
}`}
138140
id={`contributions-epic-${amount}`}
139141
checked={selection.amount === amount}
@@ -185,7 +187,7 @@ export const ContributionsEpicChoiceCards_unused: ReactComponent<
185187
) => {
186188
return (
187189
<ChoiceCard
188-
label={contributionType[frequency].label}
190+
label={contributionType_unused[frequency].label}
189191
value={frequency}
190192
id={`contributions-epic-${frequency}`}
191193
checked={selection.frequency === frequency}

dotcom-rendering/src/components/marketing/hooks/useChoiceCards.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { useEffect, useState } from 'react';
1515
import type { BannerEnrichedCta } from '../banners/common/types';
1616
import type { SupportTier } from '../epics/utils/threeTierChoiceCardAmounts';
1717
import { threeTierChoiceCardAmounts } from '../epics/utils/threeTierChoiceCardAmounts';
18-
import type { ChoiceCardSelection } from '../lib/choiceCards';
18+
import type { ChoiceCardSelection_unused } from '../lib/choiceCards';
1919
import {
2020
addChoiceCardsOneTimeParams,
2121
addChoiceCardsProductParams,
@@ -51,14 +51,16 @@ const useChoiceCards_unused = (
5151
primaryCtaMain: BannerEnrichedCta | null,
5252
primaryCtaMobile: BannerEnrichedCta | null,
5353
): {
54-
choiceCardSelection: ChoiceCardSelection | undefined;
55-
setChoiceCardSelection: (choiceCardSelection: ChoiceCardSelection) => void;
54+
choiceCardSelection: ChoiceCardSelection_unused | undefined;
55+
setChoiceCardSelection: (
56+
choiceCardSelection: ChoiceCardSelection_unused,
57+
) => void;
5658
getCtaText: (contentType: ContentType) => string;
5759
getCtaUrl: (contentType: ContentType) => string;
5860
currencySymbol: string;
5961
} => {
6062
const [choiceCardSelection, setChoiceCardSelection] = useState<
61-
ChoiceCardSelection | undefined
63+
ChoiceCardSelection_unused | undefined
6264
>();
6365

6466
useEffect(() => {

dotcom-rendering/src/components/marketing/lib/choiceCards.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import type {
1212
ChoiceCardsSettings,
1313
} from '@guardian/support-dotcom-components/dist/shared/types/props/choiceCards';
1414

15-
export interface ChoiceCardSelection {
15+
export interface ChoiceCardSelection_unused {
1616
frequency: ContributionFrequency;
1717
amount: number | 'other';
1818
}
1919

20-
export const contributionType: ContributionType = {
20+
export const contributionType_unused: ContributionType = {
2121
ONE_OFF: {
2222
label: 'One-time',
2323
suffix: '',

0 commit comments

Comments
 (0)