Skip to content

Commit c9cabe5

Browse files
Merge pull request #14269 from guardian/jsh/no-subnav-for-interactives
Do not render subnav for interactive articles
2 parents e266ca7 + 5eabfec commit c9cabe5

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

dotcom-rendering/src/layouts/FullPageInteractiveLayout.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ interface AppsProps extends CommonProps {
4949
type HeaderProps = {
5050
article: ArticleDeprecated;
5151
NAV: NavType;
52-
format: ArticleFormat;
5352
renderAds?: boolean;
5453
};
5554

@@ -143,7 +142,7 @@ const Renderer = ({
143142
return <div css={adStyles}>{output}</div>;
144143
};
145144

146-
const NavHeader = ({ article, NAV, format, renderAds }: HeaderProps) => {
145+
const NavHeader = ({ article, NAV, renderAds }: HeaderProps) => {
147146
return (
148147
<section
149148
/* Note, some interactives require this - e.g. https://www.theguardian.com/environment/ng-interactive/2015/jun/05/carbon-bomb-the-coal-boom-choking-china. */
@@ -177,7 +176,7 @@ const NavHeader = ({ article, NAV, format, renderAds }: HeaderProps) => {
177176
discussionApiUrl={article.config.discussionApiUrl}
178177
idApiUrl={article.config.idApiUrl}
179178
contributionsServiceUrl={article.contributionsServiceUrl}
180-
showSubNav={format.theme !== ArticleSpecial.Labs}
179+
showSubNav={false}
181180
showSlimNav={true}
182181
hasPageSkin={false}
183182
hasPageSkinContentSelfConstrain={false}
@@ -226,7 +225,6 @@ export const FullPageInteractiveLayout = (props: WebProps | AppsProps) => {
226225
<NavHeader
227226
article={article}
228227
NAV={props.NAV}
229-
format={format}
230228
renderAds={renderAds}
231229
/>
232230

dotcom-rendering/src/layouts/InteractiveLayout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ export const InteractiveLayout = (props: WebProps | AppsProps) => {
288288
discussionApiUrl={article.config.discussionApiUrl}
289289
idApiUrl={article.config.idApiUrl}
290290
contributionsServiceUrl={contributionsServiceUrl}
291-
showSubNav={format.theme !== ArticleSpecial.Labs}
292291
showSlimNav={true}
292+
showSubNav={false}
293293
hasPageSkin={false}
294294
hasPageSkinContentSelfConstrain={false}
295295
pageId={article.pageId}

0 commit comments

Comments
 (0)