refactoring

Author: shtukas

dotcom-rendering/src/components/SignInGate/displayRule.test.ts

@@ -0,0 +1,118 @@
+import { incrementDailyArticleCount } from '../../lib/dailyArticleCount';
+import {
+	isNPageOrHigherPageView,
+	isValidContentType,
+	isValidSection,
+	isValidTag,
+	pageIdIsAllowedForGating,
+} from './displayRules';
+
+describe('isNPageOrHigherPageView', () => {
+	beforeEach(() => {
+		localStorage.clear();
+	});
+
+	test('default - checks for is 2 article views returns true', () => {
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+
+		const output = isNPageOrHigherPageView();
+
+		expect(output).toBe(true);
+	});
+
+	test('default - checks for higher 2 article views returns true', () => {
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+
+		const output = isNPageOrHigherPageView();
+
+		expect(output).toBe(true);
+	});
+
+	test('default - checks for lower than 2 article views returns false', () => {
+		incrementDailyArticleCount();
+
+		const output = isNPageOrHigherPageView();
+
+		expect(output).toBe(false);
+	});
+
+	test('default - checks for is n = 3 article views returns true', () => {
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+
+		const output = isNPageOrHigherPageView(3);
+
+		expect(output).toBe(true);
+	});
+
+	test('default - checks for is n = 5 article views returns false', () => {
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+		incrementDailyArticleCount();
+
+		const output = isNPageOrHigherPageView(5);
+
+		expect(output).toBe(false);
+	});
+});
+
+describe('isValidContentType', () => {
+	test('is a valid type - article', () => {
+		expect(isValidContentType('Article')).toBe(true);
+	});
+
+	test('is not a valid type - LiveBlog', () => {
+		expect(isValidContentType('LiveBlog')).toBe(false);
+	});
+});
+
+describe('isValidSection', () => {
+	test('is valid section - politics - returns true', () => {
+		expect(isValidSection('politics')).toBe(true);
+	});
+
+	test('is valid section - membership - return false', () => {
+		expect(isValidSection('membership')).toBe(false);
+	});
+});
+
+describe('isValidTag', () => {
+	test('is valid tag - us-news/us-news - returns true', () => {
+		expect(
+			isValidTag([
+				{
+					id: 'us-news/us-news',
+					type: 'Keyword',
+					title: 'US news',
+				},
+			]),
+		).toBe(true);
+	});
+
+	test('is valid tag - info/newsletter-sign-up - return false', () => {
+		expect(
+			isValidTag([
+				{
+					id: 'info/newsletter-sign-up',
+					type: 'Keyword',
+					title: 'Newsletters',
+				},
+			]),
+		).toBe(false);
+	});
+});
+
+describe('articleIdentifierIsAllowed', () => {
+	expect(
+		pageIdIsAllowedForGating(
+			'money/2017/mar/10/ministers-to-criminalise-use-of-ticket-tout-harvesting-software',
+		),
+	).toBe(true);
+	expect(pageIdIsAllowedForGating('tips')).toBe(false);
+	expect(pageIdIsAllowedForGating('tips#test')).toBe(false);
+	expect(pageIdIsAllowedForGating('tips/test')).toBe(false);
+});

dotcom-rendering/src/components/SignInGate/displayRules.test.ts

@@ -1,7 +1,7 @@
 import { startPerformanceMeasure } from '@guardian/libs';
 import React, { Suspense } from 'react';
 import { Lazy } from '../../Lazy';
-import { canShowSignInGateWithOffers } from '../displayRule';
+import { canShowSignInGateWithOffers } from '../displayRules';
 import type { SignInGateComponent } from '../types';
 
 const SignInGateMain = React.lazy(() => {

dotcom-rendering/src/components/SignInGate/displayRule.ts renamed to dotcom-rendering/src/components/SignInGate/displayRules.ts

@@ -1,7 +1,7 @@
 import { startPerformanceMeasure } from '@guardian/libs';
 import React, { Suspense } from 'react';
 import { Lazy } from '../../Lazy';
-import { canShowSignInGateWithOffers } from '../displayRule';
+import { canShowSignInGateWithOffers } from '../displayRules';
 import type { SignInGateComponent } from '../types';
 
 const SignInGateCustomizableText = React.lazy(() => {

dotcom-rendering/src/components/SignInGate/gates/alternative-wording-control.tsx

@@ -1,7 +1,7 @@
 import { startPerformanceMeasure } from '@guardian/libs';
 import React, { Suspense } from 'react';
 import { Lazy } from '../../Lazy';
-import { canShowSignInGateWithOffers } from '../displayRule';
+import { canShowSignInGateWithOffers } from '../displayRules';
 import type { SignInGateComponent } from '../types';
 
 const SignInGateCustomizableText = React.lazy(() => {

dotcom-rendering/src/components/SignInGate/gates/alternative-wording-guardian-live.tsx

@@ -1,7 +1,7 @@
 import { startPerformanceMeasure } from '@guardian/libs';
 import React, { Suspense } from 'react';
 import { Lazy } from '../../Lazy';
-import { canShowSignInGate } from '../displayRule';
+import { canShowSignInGate } from '../displayRules';
 import type { SignInGateComponent } from '../types';
 
 const SignInGateFakeSocial = React.lazy(() => {

dotcom-rendering/src/components/SignInGate/gates/alternative-wording-saturday-edition.tsx

@@ -4,7 +4,7 @@ import {
 	isValidContentType,
 	isValidSection,
 	isValidTag,
-} from '../displayRule';
+} from '../displayRules';
 import type { CanShowGateProps, SignInGateComponent } from '../types';
 
 const canShow = ({

dotcom-rendering/src/components/SignInGate/gates/fake-social-variant.tsx

@@ -1,7 +1,7 @@
 import { startPerformanceMeasure } from '@guardian/libs';
 import React, { Suspense } from 'react';
 import { Lazy } from '../../Lazy';
-import { canShowSignInGateMandatory } from '../displayRule';
+import { canShowSignInGateMandatory } from '../displayRules';
 import type { SignInGateComponent } from '../types';
 
 const SignInGateMain = React.lazy(() => {

dotcom-rendering/src/components/SignInGate/gates/main-control.ts

@@ -1,7 +1,7 @@
 import { isUndefined, startPerformanceMeasure } from '@guardian/libs';
 import React, { Suspense } from 'react';
 import { Lazy } from '../../Lazy';
-import { canShowSignInGate } from '../displayRule';
+import { canShowSignInGate } from '../displayRules';
 import type { SignInGateComponent } from '../types';
 
 const SignInGateMain = React.lazy(() => {