removing console logs

adding additional unit tests

Author: charleycampbell

dotcom-rendering/src/components/EnhanceAffiliateLinks.importable.tsx

@@ -59,18 +59,14 @@ export const EnhanceAffiliateLinks = () => {
 		const allLinksOnPage = [...document.querySelectorAll('a')];
 
 		const urlParams = new URLSearchParams(window.location.search);
-		console.log('urlParams:', urlParams.toString());
 
 		const referrerURLParams = new URLSearchParams(
 			document.referrer.split('?')[1] ?? '',
 		);
-		console.log('referrerURLParams:', referrerURLParams.toString());
 
 		const utmParamsFromArticleURL = getUtmString(urlParams, utmKeys);
-		console.log('utmString:', utmParamsFromArticleURL);
 
 		const utmParamsFromReferrer = getUtmString(referrerURLParams, utmKeys);
-		console.log('utmFromReferrer:', utmParamsFromReferrer);
 
 		const utmParamsString =
 			utmParamsFromArticleURL && utmParamsFromArticleURL.trim() !== ''

dotcom-rendering/src/components/EnhanceAffiliateLinks.test.tsx

@@ -82,8 +82,7 @@ describe('EnhanceAffiliateLinks', () => {
 		);
 	});
 
-	it('should include UTM parameters in xcust if present', () => {
-		// replace window.location safely
+	it('should use article URL UTM parameters when present', () => {
 		Object.defineProperty(window, 'location', {
 			value: new URL(
 				'https://example.test/this?utm_source=growth&utm_medium=epicuk&utm_campaign=q3_test&utm_content=filter_general',
@@ -100,4 +99,54 @@ describe('EnhanceAffiliateLinks', () => {
 			'utm_source%7Cgrowth%7Cutm_medium%7Cepicuk%7Cutm_campaign%7Cq3_test%7Cutm_content%7Cfilter_general',
 		);
 	});
+
+	it('should use UTM parameters from the referrer if the article URL has none', () => {
+		Object.defineProperty(window, 'location', {
+			value: new URL('https://example.test/page'),
+			configurable: true,
+		});
+
+		Object.defineProperty(document, 'referrer', {
+			value: 'https://foo.bar/some?utm_source=testsource&utm_medium=somemedium&utm_campaign=refcamp',
+			configurable: true,
+		});
+
+		document.body.innerHTML = `
+		<a href="https://go.skimresources.com/?id=12345">Skimlink</a>
+	`;
+
+		render(<EnhanceAffiliateLinks />);
+
+		const link = document.querySelector('a');
+
+		expect(link?.href).toContain(
+			'utm_source%7Ctestsource%7Cutm_medium%7Csomemedium%7Cutm_campaign%7Crefcamp',
+		);
+	});
+
+	it('should use UTM parameters from the article URL over the referrer if both exist', () => {
+		Object.defineProperty(window, 'location', {
+			value: new URL(
+				'https://example.test/page?utm_source=pagegrow&utm_medium=somemedium',
+			),
+			configurable: true,
+		});
+
+		Object.defineProperty(document, 'referrer', {
+			value: 'https://foo.bar?utm_source=refgrow&utm_medium=refmed',
+			configurable: true,
+		});
+
+		document.body.innerHTML = `
+		<a href="https://go.skimresources.com/?id=12345">Skimlink</a>
+	`;
+
+		render(<EnhanceAffiliateLinks />);
+
+		const link = document.querySelector('a');
+		expect(link?.href).toContain(
+			'utm_source%7Cpagegrow%7Cutm_medium%7Csomemedium',
+		);
+		expect(link?.href).not.toContain('refgrow');
+	});
 });