Skip to content

Commit d0e70a6

Browse files
committed
Use primaryHeadingText in horizontal cards
1 parent 041754f commit d0e70a6

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

dotcom-rendering/fixtures/manual/productBlockElement.ts

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
import { extractHeadingText } from '../../src/model/enhanceProductElement';
12
import type { ProductBlockElement } from '../../src/types/content';
23
import { productImage } from './productImage';
34

45
export const exampleProduct: ProductBlockElement = {
56
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
67
elementId: 'b1f6e8e2-3f3a-4f0c-8d1e-5f3e3e3e3e3e',
78
primaryHeadingHtml: 'Best overall',
9+
primaryHeadingText: extractHeadingText('Best overall'),
810
secondaryHeadingHtml: 'Bosch Sky Kettle',
911
brandName: 'Bosch',
1012
productName: 'Sky Kettle',
@@ -246,6 +248,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
246248
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
247249
elementId: 'b85ec38b-091b-40c2-8902-a9114df3cfe3',
248250
primaryHeadingHtml: '<em>Best running watch for beginners:</em>',
251+
primaryHeadingText: extractHeadingText(
252+
'<em>Best running watch for beginners:</em>',
253+
),
249254
secondaryHeadingHtml: 'Garmin Forerunner 55',
250255
brandName: 'Garmin',
251256
productName: 'Forerunner 55',
@@ -282,6 +287,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
282287
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
283288
elementId: '1cb32565-86fa-4d95-a944-de49a065e71e',
284289
primaryHeadingHtml: '<em>Best budget running watch:</em>',
290+
primaryHeadingText: extractHeadingText(
291+
'<em>Best budget running watch:</em>',
292+
),
285293
secondaryHeadingHtml: 'Suunto Run',
286294
brandName: 'Suunto',
287295
productName: 'Run',
@@ -317,6 +325,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
317325
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
318326
elementId: '43670bc5-00f2-460d-853e-3e6e0bf205c5',
319327
primaryHeadingHtml: '<em>Best mid-range running watch:</em>',
328+
primaryHeadingText: extractHeadingText(
329+
'<em>Best mid-range running watch:</em>',
330+
),
320331
secondaryHeadingHtml: 'Coros Pace Pro',
321332
brandName: 'Coros',
322333
productName: 'Pace Pro',
@@ -352,6 +363,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
352363
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
353364
elementId: '830b3256-bd3a-4fc2-a4a3-6d42fcf0467f',
354365
primaryHeadingHtml: '<em>Best-looking mid-range running watch:</em>',
366+
primaryHeadingText: extractHeadingText(
367+
'<em>Best-looking mid-range running watch:</em>',
368+
),
355369
secondaryHeadingHtml: 'Suunto Race 2',
356370
brandName: 'Suunto',
357371
productName: 'Race 2',
@@ -387,6 +401,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
387401
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
388402
elementId: '407575ba-5898-4995-a94b-f7ab624c60de',
389403
primaryHeadingHtml: '<em>The best running watch money can buy:</em>',
404+
primaryHeadingText: extractHeadingText(
405+
'<em>The best running watch money can buy:</em>',
406+
),
390407
secondaryHeadingHtml: 'Garmin Forerunner 970',
391408
brandName: 'Garmin',
392409
productName: 'Forerunner 970',
@@ -422,6 +439,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
422439
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
423440
elementId: 'd7de82bb-fd1c-4efb-a54d-9844156db9e5',
424441
primaryHeadingHtml: '<em>Best running watch for battery life:</em>',
442+
primaryHeadingText: extractHeadingText(
443+
'<em>Best running watch for battery life:</em>',
444+
),
425445
secondaryHeadingHtml: 'Garmin Enduro 3',
426446
brandName: 'Garmin',
427447
productName: 'Enduro 3',
@@ -457,6 +477,9 @@ export const exampleAtAGlanceProductArray: ProductBlockElement[] = [
457477
_type: 'model.dotcomrendering.pageElements.ProductBlockElement',
458478
elementId: 'c75a0b5a-929e-4550-a146-ccc080c76655',
459479
primaryHeadingHtml: '<em>Best running watch with LTE/satellite:</em>',
480+
primaryHeadingText: extractHeadingText(
481+
'<em>Best running watch with LTE/satellite:</em>',
482+
),
460483
secondaryHeadingHtml: 'Garmin Fenix 8 Pro',
461484
brandName: 'Garmin',
462485
productName: 'Fenix 8 Pro',

dotcom-rendering/src/components/HorizontalSummaryProductCard.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,7 @@ export const HorizontalSummaryProductCard = ({
9494
/>
9595
</div>
9696
<div css={informationContainer}>
97-
<div
98-
css={productCardHeading}
99-
dangerouslySetInnerHTML={{
100-
__html: product.primaryHeadingHtml,
101-
}}
102-
></div>
97+
<div css={productCardHeading}>{product.primaryHeadingText}</div>
10398
<div css={secondaryHeading}>{product.secondaryHeadingHtml}</div>
10499
<a href={`#${product.h2Id}`} css={readMore}>
105100
Read more

0 commit comments

Comments
 (0)