Skip to content

Commit d7d2cb6

Browse files
committed
Update BrandingLabel stories to contain Labs and non Labs variations
1 parent ec228b0 commit d7d2cb6

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

dotcom-rendering/src/components/BrandingLabel.stories.tsx

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { BrandingLabel } from './BrandingLabel';
33

44
const meta: Meta<typeof BrandingLabel> = {
55
component: BrandingLabel,
6-
title: 'Components/BrandingLabel For Labs',
6+
title: 'Components/BrandingLabel',
77
parameters: {
88
layout: 'centered',
99
chromatic: {
@@ -33,27 +33,35 @@ const meta: Meta<typeof BrandingLabel> = {
3333
sponsorName: 'Guardian Org',
3434
aboutThisLink: '#about',
3535
},
36-
isLabs: true,
3736
},
3837
};
3938

4039
export default meta;
4140

42-
export const HorizontalOrientation = {
41+
export const Default = {
42+
args: {
43+
isLabs: false,
44+
},
45+
};
46+
47+
export const LabsHorizontalOrientation = {
4348
args: {
49+
isLabs: true,
4450
orientation: 'horizontal',
4551
},
4652
};
4753

48-
export const VerticalOrientation = {
54+
export const LabsVerticalOrientation = {
4955
args: {
56+
isLabs: true,
5057
orientation: 'vertical',
5158
},
5259
};
5360

54-
export const VerticalRightAlignment = {
61+
export const LabsVerticalRightAlignment = {
5562
args: {
56-
alignment: 'end',
63+
isLabs: true,
5764
orientation: 'vertical',
65+
alignment: 'end',
5866
},
5967
};

dotcom-rendering/src/components/BrandingLabel.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type { Branding } from '../types/branding';
1313
import type { DCRContainerPalette } from '../types/front';
1414
import { useConfig } from './ConfigContext';
1515

16-
type SponsoredContentLabelProps = {
16+
type Props = {
1717
branding: Branding;
1818
alignment?: 'start' | 'end';
1919
orientation?: 'horizontal' | 'vertical';
@@ -115,7 +115,7 @@ export const BrandingLabel = ({
115115
ophanComponentName,
116116
isLabs = false,
117117
isAdvertisingPartner = false,
118-
}: SponsoredContentLabelProps) => {
118+
}: Props) => {
119119
const { darkModeAvailable } = useConfig();
120120
const logo = decideBrandingLogo(branding, containerPalette);
121121

@@ -195,7 +195,7 @@ export const BrandingLabel = ({
195195
isAdvertisingPartner && imageAdvertisingPartnerStyles,
196196
]}
197197
src={logo.src}
198-
alt={''}
198+
alt={`logo for ${branding.sponsorName}`}
199199
/>
200200
</a>
201201
);

0 commit comments

Comments
 (0)