Skip to content

Commit d802b3e

Browse files
isMaybeLater is default for two step banner (#15005)
* isMaybeLater is default for two step banner * do not show close button in two step banner
1 parent abedcb4 commit d802b3e

File tree

1 file changed

+13
-39
lines changed

1 file changed

+13
-39
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 13 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -291,12 +291,6 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
291291
separateArticleCount) &&
292292
articleCounts.forTargetedWeeks >= 5;
293293

294-
// Add detection for the new "Maybe later" AB variant and pass flag to CTAs.
295-
// This reuses the existing onCloseClick handler (same behaviour as the Close link).
296-
const isMaybeLaterVariant = tracking.abTestVariant.includes(
297-
'COLLAPSABLE_V2_MAYBE_LATER',
298-
);
299-
300294
return (
301295
<div
302296
ref={bannerRef}
@@ -313,7 +307,6 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
313307
isCollapsableBanner && isCollapsed
314308
? styles.collapsedLayoutOverrides(
315309
cardsImageOrSpaceTemplateString,
316-
isMaybeLaterVariant,
317310
)
318311
: styles.layoutOverrides(
319312
cardsImageOrSpaceTemplateString,
@@ -412,9 +405,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
412405
templateSettings.secondaryCtaSettings
413406
}
414407
onCloseClick={
415-
isMaybeLaterVariant && isCollapsed
416-
? onCloseClick
417-
: undefined
408+
isCollapsed ? onCloseClick : undefined
418409
}
419410
/>
420411
</div>
@@ -426,7 +417,6 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
426417
isCollapsableBanner
427418
? styles.closeAndCollapseButtonContainer(
428419
isCollapsed,
429-
isMaybeLaterVariant,
430420
)
431421
: styles.closeButtonContainer
432422
}
@@ -462,14 +452,13 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
462452
/>
463453
</div>
464454
)}
465-
{(!isCollapsableBanner || isCollapsed) &&
466-
!isMaybeLaterVariant && (
467-
<DesignableBannerCloseButton
468-
onCloseClick={onCloseClick}
469-
settings={templateSettings.closeButtonSettings}
470-
isCollapsableBanner={isCollapsableBanner}
471-
/>
472-
)}
455+
{!isCollapsableBanner && (
456+
<DesignableBannerCloseButton
457+
onCloseClick={onCloseClick}
458+
settings={templateSettings.closeButtonSettings}
459+
isCollapsableBanner={isCollapsableBanner}
460+
/>
461+
)}
473462
</div>
474463

475464
{choiceCards &&
@@ -521,7 +510,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
521510
? mainOrMobileContent.primaryCta.ctaText
522511
: 'Continue'}
523512
</LinkButton>
524-
{isMaybeLaterVariant && isCollapsed && (
513+
{isCollapsed && (
525514
<div css={styles.maybeLaterButtonSizing}>
526515
<LinkButton
527516
onClick={onCloseClick}
@@ -637,10 +626,7 @@ const styles = {
637626
'. vert-line cta-container ${cardsImageOrSpaceTemplateString} .';
638627
}
639628
`,
640-
collapsedLayoutOverrides: (
641-
cardsImageOrSpaceTemplateString: string,
642-
isMaybeLaterVariant: boolean,
643-
) => css`
629+
collapsedLayoutOverrides: (cardsImageOrSpaceTemplateString: string) => css`
644630
display: grid;
645631
background: inherit;
646632
position: relative;
@@ -652,18 +638,11 @@ const styles = {
652638
margin: 0 auto;
653639
padding: ${space[2]}px ${space[3]}px 0 ${space[3]}px;
654640
grid-template-columns: auto max(${phabletContentMaxWidth} auto);
655-
grid-template-areas: ${isMaybeLaterVariant
656-
? `
641+
grid-template-areas: ${`
657642
'. . .'
658643
'. copy-container close-button'
659644
'. ${cardsImageOrSpaceTemplateString} ${cardsImageOrSpaceTemplateString}'
660645
'. cta-container cta-container'
661-
`
662-
: `
663-
'. close-button .'
664-
'. copy-container .'
665-
'. ${cardsImageOrSpaceTemplateString} .'
666-
'. cta-container .';
667646
`};
668647
}
669648
${from.phablet} {
@@ -748,10 +727,7 @@ const styles = {
748727
padding-left: ${space[8]}px;
749728
}
750729
`,
751-
closeAndCollapseButtonContainer: (
752-
isCollapsed: boolean,
753-
isMaybeLaterVariant: boolean,
754-
) => css`
730+
closeAndCollapseButtonContainer: (isCollapsed: boolean) => css`
755731
/* Layout changes only here */
756732
grid-area: close-button;
757733
display: flex;
@@ -770,9 +746,7 @@ const styles = {
770746
}
771747
${from.desktop} {
772748
flex-direction: ${isCollapsed ? 'row' : 'row-reverse'};
773-
margin-top: ${isCollapsed && isMaybeLaterVariant
774-
? space[9]
775-
: space[6]}px;
749+
margin-top: ${isCollapsed ? space[9] : space[6]}px;
776750
}
777751
778752
.maybe-later & {

0 commit comments

Comments
 (0)