Skip to content

Commit d83aa26

Browse files
committed
Image position is none if no image
1 parent a875927 commit d83aa26

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

dotcom-rendering/src/components/Card/Card.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1064,8 +1064,12 @@ export const Card = ({
10641064
imageType={media?.type}
10651065
imageSize={imageSize}
10661066
isBetaContainer={isBetaContainer}
1067-
imagePositionOnDesktop={imagePositionOnDesktop}
1068-
imagePositionOnMobile={imagePositionOnMobile}
1067+
imagePositionOnDesktop={
1068+
image ? imagePositionOnDesktop : 'none'
1069+
}
1070+
imagePositionOnMobile={
1071+
image ? imagePositionOnMobile : 'none'
1072+
}
10691073
padContent={determinePadContent(
10701074
isMediaCardOrNewsletter,
10711075
isBetaContainer,

dotcom-rendering/src/components/FlexibleGeneral.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,6 @@ export const StandardCardLayout = ({
436436
containerPalette,
437437
showAge,
438438
absoluteServerTimes,
439-
showImage = true,
440439
imageLoading,
441440
isFirstRow,
442441
isFirstStandardRow,
@@ -451,7 +450,6 @@ export const StandardCardLayout = ({
451450
containerPalette?: DCRContainerPalette;
452451
showAge?: boolean;
453452
absoluteServerTimes: boolean;
454-
showImage?: boolean;
455453
aspectRatio: AspectRatio;
456454
isLastRow: boolean;
457455
containerLevel: DCRContainerLevel;
@@ -485,7 +483,7 @@ export const StandardCardLayout = ({
485483
containerType="flexible/general"
486484
showAge={showAge}
487485
absoluteServerTimes={absoluteServerTimes}
488-
image={showImage ? card.image : undefined}
486+
image={card.image}
489487
imageLoading={imageLoading}
490488
imagePositionOnDesktop="left"
491489
supportingContent={card.supportingContent?.slice(

0 commit comments

Comments
 (0)